Bug 278831 - [block selection] Block selection font size not honored
Summary: [block selection] Block selection font size not honored
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5.2   Edit
Assignee: Tom Hofmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-02 13:24 EDT by Markus Keller CLA
Modified: 2010-01-21 01:36 EST (History)
2 users (show)

See Also:

Attachments
Patch against AbstractTextEditor.java R1.309 (2.31 KB, patch)
2009-12-31 08:02 EST, Tom Hofmann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-06-02 13:24:12 EDT 
I20090601-2000 + fix for bug 278826

The block selection font size is only honored when the font is changed while an editor is in block selection mode. Otherwise, block selection always uses the font size of the normal Text Font.

I don't think it's a good strategy to keep the font size of the Text Font. Different fonts can have quite different visual sizes, so it can be necessary for the user to have the possibility to use different sizes.

It would be OK for me to take over the size as long as the block selection font has not been set explicitly.
Comment 1 Dani Megert CLA 2009-06-03 05:08:57 EDT 
We should completely remove the font-adjustment smartness so that people get the block selection font that has been chosen. User's will quickly see if the font size doesn't match and can then adjust it.

Having different font sizes for different editors plus wanting to use block selection in all of them is a negligible scenario.
Comment 2 Dani Megert CLA 2009-06-03 05:09:50 EDT 
I assume the fix is trivial enough to put into 3.5.1.
Comment 3 Tom Hofmann CLA 2009-06-03 05:32:05 EDT 
I agree - font size adaption would be nice if it would work reliably. However, the font size value has little to do with the font size perceived by the user.
Comment 4 Tom Hofmann CLA 2009-12-31 08:02:01 EST 
Created attachment 155152 [details]
Patch against AbstractTextEditor.java R1.309

Fixed in HEAD >= 2010 together with bug 278817.

The attached patch is the same code as released to HEAD, but against the R3_5_1 tag of AbstractTextEditor.java (R1.309).

Dani, there is no R3_5_maintenance branch of o.e.ui.workbench.texteditor yet. I can try to do the branching, but would really prefer if you did it in order to have everything in place.

Note that the patch also includes the fix for bug 278817.
Comment 5 Tom Hofmann CLA 2009-12-31 08:05:06 EST 
Leaving as ASSIGNED until fixed on the 3.5.x branch.
Comment 6 Dani Megert CLA 2010-01-05 08:59:59 EST 
Thanks Tom and a Happy New Year to you!

Committed patch to R3_5_maintenance and released to map file.
Comment 7 Tom Hofmann CLA 2010-01-05 09:16:04 EST 
Thanks Dani... the same to you and the rest at Zurich Lab.
Comment 8 Raksha Vasisht CLA 2010-01-21 01:36:07 EST 
Verified for 3.5.2 with build M20100120-0800.