Bug 278764 - No Restore Defaults/Apply buttons on project properties - PHP Debug
Summary: No Restore Defaults/Apply buttons on project properties - PHP Debug
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Roy Ganor CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-02 08:35 EDT by Toshihiro Izumi CLA
Modified: 2020-05-14 10:16 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Toshihiro Izumi CLA 2009-06-02 08:35:29 EDT
Project properties > PHP Debug
There are no 'Restore Defaults' and 'Apply' buttons.
Instant patch is below but I guess this page(org.eclipse.php.internal.debug.ui.preferences.PHPDebugPropertyPreferencePage) should be rewritten based on common class(?org.eclipse.php.internal.ui.preferences.PropertyAndPreferencePage?) I'm not sure.

### Eclipse Workspace Patch 1.0
#P org.eclipse.php.ui
Index: src/org/eclipse/php/internal/ui/preferences/AbstractPHPPropertyPreferencePage.java
===================================================================
RCS file: /cvsroot/tools/org.eclipse.pdt/plugins/org.eclipse.php.ui/src/org/eclipse/php/internal/ui/preferences/AbstractPHPPropertyPreferencePage.java,v
retrieving revision 1.8
diff -u -r1.8 AbstractPHPPropertyPreferencePage.java
--- src/org/eclipse/php/internal/ui/preferences/AbstractPHPPropertyPreferencePage.java	28 May 2009 19:50:38 -0000	1.8
+++ src/org/eclipse/php/internal/ui/preferences/AbstractPHPPropertyPreferencePage.java	2 Jun 2009 12:12:01 -0000
@@ -192,9 +192,9 @@
 	}
 
 	public void createControl(Composite parent) {
-		if (getProject() != null) {
-			noDefaultAndApplyButton();
-		}
+//		if (getProject() != null) {
+//			noDefaultAndApplyButton();
+//		}
 		super.createControl(parent);
 	}
Comment 1 Nitin Dahyabhai CLA 2011-04-20 16:16:52 EDT
Calling noDefaultAndApplyButton() is something you have to intentionally do.  What happens if the buttons are restored and someone actually clicks "Restore Defaults" with this patch?