Bug 278391 - Image Compare should allow visual compare of gif and png
Summary: Image Compare should allow visual compare of gif and png
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 155323
Blocks:
  Show dependency tree
 
Reported: 2009-05-29 10:15 EDT by Markus Keller CLA
Modified: 2017-07-12 05:23 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-05-29 10:15:36 EDT 
I20090528-2000

Image Compare should allow visual compare of gif and png.
Currently, I just get text compare (of binary content).
Comment 1 Tomasz Zarna CLA 2009-05-29 11:44:05 EDT 
Currently, when looking for a content merge viewer[1] and the given files have different types there is a fallback which works like this: try to guess the type[2] and if the guessed type is "text" use content merge viewer for text comparisons otherwise use the one for binaries.

I can see two solutions here:
1. Fix the first part (before we get to the fallback) and return a proper content merge viewer for files with different types (given the viewer is registered for both of the types).
2. Fix the way [2] works.

I would be happy to fix this (either way) in early 3.6 cycle.

[1] org.eclipse.compare.internal.CompareUIPlugin.findContentViewerDescriptor(Viewer, Object, CompareConfiguration)
[2] org.eclipse.compare.internal.CompareUIPlugin.guessType(ITypedElement)
Comment 2 Szymon Brandys CLA 2009-06-05 09:28:16 EDT 
The image content type (see bug 229897 and bug 106832) would also help here. If the content type is defined, we could bind ImageMergeViewerCreator to it.
Comment 3 Tomasz Zarna CLA 2010-01-28 10:35:32 EST 
I think I'm leaning towards Szymon's suggestion to make use of defined content types to solve this issue. So, I'm marking this as blocked by bug 106832. Once it's fixed, we'll go back to this one.