Bug 278102 - add quick outline to task editor and provide quick access to related tasks
Summary: add quick outline to task editor and provide quick access to related tasks
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement with 1 vote (vote)
Target Milestone: 3.4   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted, noteworthy
: 173810 250506 (view as bug list)
Depends on:
Blocks: 314736
  Show dependency tree
 
Reported: 2009-05-27 14:41 EDT by Mik Kersten CLA
Modified: 2011-01-12 15:03 EST (History)
9 users (show)

See Also:


Attachments
patchV1 (42.76 KB, patch)
2010-05-03 15:44 EDT, Frank Becker CLA
eclipse: review?
Details | Diff
mylyn/context/zip (42.02 KB, application/octet-stream)
2010-05-03 15:48 EDT, Frank Becker CLA
no flags Details
patch V2 (70.64 KB, patch)
2010-05-23 16:03 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (144.69 KB, application/octet-stream)
2010-05-23 16:03 EDT, Frank Becker CLA
no flags Details
v3 (53.71 KB, patch)
2010-05-24 03:09 EDT, Steffen Pingel CLA
no flags Details | Diff
screen shot (32.87 KB, image/png)
2010-05-24 03:21 EDT, Steffen Pingel CLA
no flags Details
patch V4 (60.40 KB, patch)
2010-05-24 15:18 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (29.23 KB, application/octet-stream)
2010-05-24 15:18 EDT, Frank Becker CLA
no flags Details
updated patch V4 (57.12 KB, patch)
2010-05-24 15:45 EDT, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (5.90 KB, application/octet-stream)
2010-05-24 15:45 EDT, Frank Becker CLA
no flags Details
screen shot (41.20 KB, image/png)
2010-05-24 17:39 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mik Kersten CLA 2009-05-27 14:41:12 EDT
Stick all attributes in it so that the following works:
* Ctrl+O
* Type "ver"
* Jump into value of Version attribute
Comment 1 Steffen Pingel CLA 2009-05-27 16:31:21 EDT
+1 

I would also like to have a quick way to navigate to dependent tasks that way.
Comment 2 Jörg Thönnes CLA 2009-08-12 06:10:43 EDT
+1

And if the References section is to be added I could also navigate to related tasks.
Comment 3 Steffen Pingel CLA 2009-08-13 03:22:48 EDT
*** Bug 250506 has been marked as a duplicate of this bug. ***
Comment 4 Steffen Pingel CLA 2009-08-13 03:29:08 EDT
*** Bug 173810 has been marked as a duplicate of this bug. ***
Comment 5 Jörg Thönnes CLA 2009-11-02 07:19:06 EST
Any plans when this and the related bug 165859 will be implemented?
Comment 6 Steffen Pingel CLA 2009-11-02 12:15:06 EST
The request is part of the backlog and we'll consider it when planning the next release cycle.
Comment 7 Mik Kersten CLA 2009-11-05 12:34:07 EST
Anyone interested in contributing this?  It should be straightforward since it would just take our current outline contents and put them into a quick outline.
Comment 8 Frank Becker CLA 2010-04-15 23:58:40 EDT
(In reply to comment #7)
> Anyone interested in contributing this?  It should be straightforward since it
> would just take our current outline contents and put them into a quick outline.

Mik

should I look into this after I have finished the Bugzilla Webservice support for 3.6?

Thougths?
Comment 9 Mik Kersten CLA 2010-04-27 20:23:54 EDT
Frank: The content that we are going to show is a bit tricky and we need to have more design discussions.  What would be great is if you could contribute a quick outline view that includes the current outline contents, and then we can later figure out how to improve what content goes there.  You can wire this to Ctrl+O for now, and then we can figure out how to add a visible button/link to pop it up later.  After you have the outline working, you could add a node for Subtasks, etc, or suggest other improvements that you would like to see.  Are you interested in doing this for Mylyn 3.4?  Would be a great feature to have for that, but we would need to wrap it up within the next 3 weeks.
Comment 10 Steffen Pingel CLA 2010-04-27 21:00:51 EDT
Frank, this would be a valuable feature and you could take a look at QuickContextPopupDialog for some ideas how to implement that.
Comment 11 Frank Becker CLA 2010-04-29 15:08:07 EDT
I start now and look what I can do.
Comment 12 Frank Becker CLA 2010-05-03 15:44:25 EDT
Created attachment 166862 [details]
patchV1

M!+M2+M3+. is used for open the quickview.

Actual no operation are shown. Also we did not chow TaskAttribues of Comments and Attachments.

Please verify this as soon as possible.
Comment 13 Frank Becker CLA 2010-05-03 15:48:21 EDT
Created attachment 166864 [details]
mylyn/context/zip
Comment 14 Steffen Pingel CLA 2010-05-18 18:09:09 EDT
This looks like a really good start. I am a bit concerned that the flexibility provided by the common navigator is not really needed in this case but a simple tree viewer as it is used by the outline view would suffice. I apologize if comment 10 was misleading in that regard. I meant that as an example how to implement a popup with an embedded tree viewer but not necessarily as a template for the actual viewer. 

I think it would be nice if the viewer code could be shared with the outline including the icons and hierarchy but show additional nodes for attributes, linked tasks etc.
Comment 15 Jörg Thönnes CLA 2010-05-19 06:38:05 EDT
Will we see this for 3.4? This would be great.
Comment 16 Steffen Pingel CLA 2010-05-19 10:40:30 EDT
If we can fix the outstanding issues within the next week we'll consider this for  inclusion in 3.4.
Comment 17 Jörg Thönnes CLA 2010-05-20 02:57:51 EDT
Great, thanks.
Comment 18 Frank Becker CLA 2010-05-23 16:03:33 EDT
Created attachment 169620 [details]
patch V2

Steffen

here is a new version.

Now we have 
a) support for Outline Elements (I add support for attachments)
b) show of the row Taskdata

can you please review this patch.
Comment 19 Frank Becker CLA 2010-05-23 16:03:38 EDT
Created attachment 169621 [details]
mylyn/context/zip
Comment 20 Steffen Pingel CLA 2010-05-24 03:09:40 EDT
Created attachment 169632 [details]
v3
Comment 21 Steffen Pingel CLA 2010-05-24 03:21:39 EDT
Created attachment 169633 [details]
screen shot
Comment 22 Steffen Pingel CLA 2010-05-24 03:22:04 EDT
Thanks. I have taken another pass at this and done a few simplifications. The common viewer approach that you took is powerful in terms of extensibility but I want to avoid the extra complexity and the dependency on o.e.ui.navigator so I replaced the common navigator with a tree viewer. It's an interesting idea to display the entire attribute structure in the quick outline but that makes it a rather advanced introspection feature whereas for the first pass I would prefer to focus on providing quick navigation capabilities targeted at intermediate users.

The patch is still incomplete: 
* Presentation of related tasks and navigation to related tasks needs to be improved.
* Navigation to standard attributes is not yet working.
* Icons for Attributes need to be improved.
Comment 23 Frank Becker CLA 2010-05-24 15:18:45 EDT
Created attachment 169712 [details]
patch V4

(In reply to comment #22)
> 
> The patch is still incomplete: 
> * Presentation of related tasks and navigation to related tasks needs to be
> improved.
Done
> * Navigation to standard attributes is not yet working.
Done
> * Icons for Attributes need to be improved.
Still open. Should we create an icon for every attribute?

I changed the sequence="M1+O" to sequence="M1+M2+O" because of an conflict with org.eclipse.mylyn.wikitext.ui.quickOutlineCommand
Comment 24 Frank Becker CLA 2010-05-24 15:18:49 EDT
Created attachment 169713 [details]
mylyn/context/zip
Comment 25 Frank Becker CLA 2010-05-24 15:45:30 EDT
Created attachment 169720 [details]
updated patch V4

sorry the previous patch was not complete.

Please use this.
Comment 26 Frank Becker CLA 2010-05-24 15:45:32 EDT
Created attachment 169721 [details]
mylyn/context/zip
Comment 27 Steffen Pingel CLA 2010-05-24 17:39:19 EDT
Created attachment 169738 [details]
screen shot
Comment 28 Steffen Pingel CLA 2010-05-24 17:39:33 EDT
Great! I have refined the patch further and committed it. Outstanding issues:

* Icons for categories and attributes
* Only sub-tasks are shown, other related tasks such as parent or blocks are not included
* WikiText key-binding conflict: bug 314167

I have added the bug for review to Thursday's meeting agenda.
Comment 29 Mik Kersten CLA 2010-05-27 13:50:51 EDT
In UI review on call we decided that this should be accessible from the Task Editor toolbar via some kind of drop-down style action, either a drop down button or a view menu.
Comment 30 Steffen Pingel CLA 2010-05-27 15:56:07 EDT
Some other suggestions from the UI review:

* Collapse Attributes by default
* Consider moving history button under open with web browser button
Comment 31 Steffen Pingel CLA 2010-05-28 20:39:32 EDT
Changes committed.
Comment 32 Frank Becker CLA 2010-05-29 10:27:46 EDT
(In reply to comment #29)
> In UI review on call we decided that this should be accessible from the Task
> Editor toolbar via some kind of drop-down style action, either a drop down
> button or a view menu.
Mik,
Steffen,

should I add an button with the outline icon to the Task Editor toolbar?
Comment 33 Steffen Pingel CLA 2010-05-29 14:35:00 EDT
> should I add an button with the outline icon to the Task Editor toolbar?

We tried various approaches but didn't find a satisfactory solution and decided to leave it out for now.
Comment 34 Steffen Pingel CLA 2010-05-29 14:42:19 EDT
Reopening to address problem discovered by Frank:

TaskEditorOutlinePage.setInput is called during AbstractTaskEditorPage.updateOutlinePage and this is called during refresh.

So when you do an "Synchronize Incoming Changes" or "Clear Outgoing" you only see the summary
Comment 35 Steffen Pingel CLA 2010-05-29 14:44:58 EDT
*** Bug 314981 has been marked as a duplicate of this bug. ***
Comment 36 Steffen Pingel CLA 2010-05-29 14:50:59 EDT
Closing. Bug 314981 referred to regular outline, not quick outline.
Comment 37 Sam Davis CLA 2011-01-11 19:22:46 EST
I can't expand attributes - it just closes the quick outline and scrolls the editor to attributes.
Comment 38 Steffen Pingel CLA 2011-01-11 19:38:21 EST
Try using the keyboard or filter, that works for me.
Comment 39 Sam Davis CLA 2011-01-11 20:01:51 EST
That works, but you should be able to click too.

I also notice that the behaviour in the description does not work (you have to use the down arrow too).
Comment 40 Frank Becker CLA 2011-01-12 14:51:36 EST
(In reply to comment #37)
> I can't expand attributes - it just closes the quick outline and scrolls the
> editor to attributes.

This must be platform specific. Mac OS X Cocoa 64 work perfect.

What is your platform?
Comment 41 Sam Davis CLA 2011-01-12 15:03:03 EST
Windows 7 Professional. 32 bit.