Bug 2777 - [UI] Minor: ugly style in ContentOutlinePage (1GJ6IFJ)
Summary: [UI] Minor: ugly style in ContentOutlinePage (1GJ6IFJ)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P4 normal (vote)
Target Milestone: ---   Edit
Assignee: Ryan Cooper CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:43 EDT by John Arthorne CLA
Modified: 2002-01-25 17:17 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2001-10-10 22:43:21 EDT
ContentOutlinePage creates a tree viewer that has the SWT.BORDER bit set.
This looks ugly because it is in the content outline view, and the extra border
is not necessary.  For example, compare the readme example content outline
(which uses the default viewer) to the java content outline (which creates its own widgets),
and you'll see that the ugly border in the readme outline stands out.

Simple fix: create the viewer without a border by default.
Fancy fix: put the viewer creation in a protected method so subclasses can override it.

NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 19:16:01 EST
PRODUCT VERSION:

0.131

Comment 2 Simon Arsenault CLA 2002-01-16 16:31:45 EST
Check if this is still a problem and if so, what your proposed solution(s) is.
Comment 3 Ryan Cooper CLA 2002-01-23 16:19:37 EST
Although I could not find the mentioned readme example, according to the code 
for the ContentOutlinePage class and TreeViewer class, the border is still 
being created.

My proposed solution is to create the TreeViewer for the ContentOutlinePage 
without a border by default. This will get rid of the ugly extra border and 
make the default content outline consistent with the Java content outline.
Comment 4 Simon Arsenault CLA 2002-01-25 17:17:44 EST
Fix applied and will be in build > 2005-01-25