Bug 2763 - [Dialogs] DCR: TypeFilteringDialog should be public API (1GIYHMY)
Summary: [Dialogs] DCR: TypeFilteringDialog should be public API (1GIYHMY)
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Tod Creasey CLA
QA Contact:
URL:
Whiteboard:
Keywords: api, investigate
Depends on: 24120 24121
Blocks:
  Show dependency tree
 
Reported: 2001-10-10 22:43 EDT by Dani Megert CLA
Modified: 2005-05-10 14:56 EDT (History)
0 users

See Also:

Attachments
Patch for FileTypeEditor (1.04 KB, patch)
2002-09-23 10:20 EDT, Tod Creasey CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2001-10-10 22:43:05 EDT 
The org.eclipse.ui.internal.dialogs.TypeFilteringDialog should be
	public API to guarantee that selecting a type is consistent all over
	the workbench. The same dialog is used (and had to be copied for
	now) in the Search dialog.


NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 19:15:05 EST 
PRODUCT VERSION:
	0.132
Comment 2 Kevin Haaland CLA 2002-03-27 11:14:27 EST 
Defer
Comment 3 Randy Giffen CLA 2002-08-08 15:36:22 EDT 
Reopen for investigation
Comment 4 Tod Creasey CLA 2002-09-20 15:17:27 EDT 
The two are subtley different - in the search dialog it ask for Other patterns 
and the one provided by UI asks for Other extensions.

If this is acceptable I can make this public.
Comment 5 Tod Creasey CLA 2002-09-23 10:18:40 EDT 
Moved to org.eclipse.ui.dialogs in build >20020923

Also added new constructor public TypeFilteringDialog(Shell parentShell, 
Collection preselections, String filterText) so that you can use the more 
appropriate text for your search dialog.

I will attach a patch with suggested changes for Search.
Comment 6 Tod Creasey CLA 2002-09-23 10:20:31 EDT 
Created attachment 2036 [details]
Patch for FileTypeEditor
Comment 7 Tod Creasey CLA 2002-09-23 10:20:52 EDT 
Marking as Fixed.
Comment 8 Dani Megert CLA 2002-09-26 06:20:16 EDT 
Did not switch to this dialog yet due to the following PRS:

24120: TypeFilterDialog UI and API not same
24121: "Other Extensions:" field must not show ',' at the end
Comment 9 Tod Creasey CLA 2005-05-10 14:56:02 EDT 
Marking closed