Bug 276229 - add images to the discovery UI
Summary: add images to the discovery UI
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Mik Kersten CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 272621
  Show dependency tree
 
Reported: 2009-05-13 23:15 EDT by David Green CLA
Modified: 2009-06-04 10:24 EDT (History)
1 user (show)

See Also:

Attachments
info image (267 bytes, image/gif)
2009-05-28 22:37 EDT, Mik Kersten CLA 		no flags Details
warning (591 bytes, image/gif)
2009-06-01 12:09 EDT, Mik Kersten CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Green CLA 2009-05-13 23:15:28 EDT 
* Download button icon
* Wizard banner icon
Comment 1 Mik Kersten CLA 2009-05-21 13:37:49 EDT 
* Consider making the "?" an "i"
Comment 2 Mik Kersten CLA 2009-05-26 19:20:27 EDT 
Done.  Synch up and let me know what you think.
Comment 3 David Green CLA 2009-05-26 20:55:56 EDT 
I like the wizard banner.  Is that all that changed (am I missing something)?
Comment 4 Steffen Pingel CLA 2009-05-26 21:19:06 EDT 
There is also an image on the button in the connector selection dialog.
Comment 5 David Green CLA 2009-05-26 23:20:38 EDT 
Now I see it... looks good!
Comment 6 David Green CLA 2009-05-28 20:29:01 EDT 
(i) information image is missing
Comment 7 Mik Kersten CLA 2009-05-28 22:37:15 EDT 
Created attachment 137595 [details]
info image
Comment 8 Mik Kersten CLA 2009-05-28 22:37:41 EDT 
Done.
Comment 9 David Green CLA 2009-05-29 12:03:00 EDT 
I need a warning overlay that looks good on a 32x32 icon.  
I've created one at /org.eclipse.mylyn.discovery.ui/icons/ovr32/warning.gif based on the warning task icon but it should get a review.
Comment 10 Steffen Pingel CLA 2009-05-31 04:32:11 EDT 
I have added the information image to CommonImages.
Comment 11 Mik Kersten CLA 2009-06-01 12:09:35 EDT 
Created attachment 137866 [details]
warning
Comment 12 Mik Kersten CLA 2009-06-01 12:10:08 EDT 
Done.
Comment 13 Steffen Pingel CLA 2009-06-04 00:58:49 EDT 
The warning icon is barely noticeable when it's grayed out. I would also expect to get some kind of tooltip with a more detailed error message, e.g. "Failed to connect to site ... ". Would it make sense to gray out the logo only and display the warning icon instead of the checkbox if a connector is not available?
Comment 14 David Green CLA 2009-06-04 01:04:24 EDT 
(In reply to comment #13)
> I would also expect to get some kind of tooltip with a more detailed error message, e.g. "Failed to
> connect to site ... ". 

You'll get the message if you click on it.  I tried tooltips for that purpose and found it to be anoying.

> Would it make sense to gray out the logo only and display
> the warning icon instead of the checkbox if a connector is not available?

That's a good idea.
Comment 15 David Green CLA 2009-06-04 10:23:45 EDT 
I've modified it so that the icon is not disabled in the case that the connector is not available.  The checkbox remains present, disabled.  This looks good and avoids issues with layout/presentation.
Comment 16 David Green CLA 2009-06-04 10:24:43 EDT 
done.  The tooltip versus dialog issue can be discussed in today's call or the next UI review.