Bug 276162 - [KeyBindings] Exporting key preferences to CSV does not warn of overwriting file
Summary: [KeyBindings] Exporting key preferences to CSV does not warn of overwriting file
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5.1   Edit
Assignee: Paul Webster CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks: 288364
  Show dependency tree
 
Reported: 2009-05-13 14:30 EDT by Mike Morearty CLA
Modified: 2009-09-02 10:37 EDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (909 bytes, patch)
2009-05-14 12:39 EDT, Mike Morearty CLA 		pwebster: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Morearty CLA 2009-05-13 14:30:33 EDT 
Build ID: I20090430-2300
Tried on both Windows and Mac.

Steps To Reproduce:
1. Preferences, General > Keys
2. Click "Export CSV..."
3. Enter any filename and click OK
4. Do it again: Click "Export CSV...", enter the same filename, and click OK.

Actual result:
The second time, it overwrites the file with no warning.

Expected result:
If you specify the name of an existing file, customary practice on all operating systems is to first warn that you are overwriting a file.
Comment 1 Mike Morearty CLA 2009-05-14 12:39:37 EDT 
Created attachment 135817 [details]
Proposed patch
Comment 2 Paul Webster CLA 2009-05-14 12:48:59 EDT 
Thanx for the patch, I'll look at this in 3.5.1
PW
Comment 3 Paul Webster CLA 2009-08-11 14:11:38 EDT 
The patch looks good (I like simple).

Boris, could I get a +1

PW
Comment 4 Boris Bokowski CLA 2009-08-12 09:44:29 EDT 
+1
Comment 5 Paul Webster CLA 2009-08-12 12:50:57 EDT 
(In reply to comment #1)
> Created an attachment (id=135817) [details]
> Proposed patch

Released to R3_5_maintenance
PW
Comment 6 Paul Webster CLA 2009-08-27 15:20:58 EDT 
In M20090826-1100
PW