Bug 27613 - Code duplication with Ant preference pages and Ant launch config tabs
Summary: Code duplication with Ant preference pages and Ant launch config tabs
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-12-03 15:45 EST by Darin Swanson CLA
Modified: 2003-02-17 20:34 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2002-12-03 15:45:44 EST 
Some code refactoring needs to be done to factor out the common widgets and 
make some code reuse happen.
Comment 1 Darin Swanson CLA 2003-02-16 01:44:39 EST 
I got tired of fixing bugs in two places :-)

Please verify changes to AntClasspathTab, AntClasspathPage, AntPropertiesTab 
and AntPropertiesPage.
New classes AntClasspathBlock, AntPropertiesBlock and IAntBlockContainer.
Comment 2 Jared Burns CLA 2003-02-17 15:54:03 EST 
Reopening for additional refactoring.
Comment 3 Jared Burns CLA 2003-02-17 16:09:22 EST 
I did some more refactoring to AntPropertiesBlock to reduce the number of
inner classes and duplicate code.

Please verify, DarinS.
Comment 4 Darin Swanson CLA 2003-02-17 20:34:03 EST 
Verified