Bug 276113 - allow typing in task data directory field
Summary: allow typing in task data directory field
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.1   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.4   Edit
Assignee: Abner Ballardo CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2009-05-13 11:18 EDT by Andrew Overholt CLA
Modified: 2010-04-03 02:23 EDT (History)
2 users (show)

See Also:


Attachments
Patch fixing bug (7.15 KB, patch)
2010-02-24 17:09 EST, Abner Ballardo CLA
steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (1.60 KB, application/octet-stream)
2010-02-24 17:09 EST, Abner Ballardo CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2009-05-13 11:18:06 EDT
I know my task data directory -- it's independent of my workspace -- and I'd like to be able to edit the preset directory name that's present.  Unfortunately, I have to go through the file chooser dialogue to pick it and that's annoying :)  Can we make that field editable?
Comment 1 Steffen Pingel CLA 2009-05-13 15:39:48 EDT
Sounds like a good idea. I think most place in platform allow you to type in the directory text boxes. 
Comment 2 Abner Ballardo CLA 2010-02-22 16:59:42 EST
Hi, I want to contribute fixing this bug
Comment 3 Steffen Pingel CLA 2010-02-22 17:14:44 EST
Go for it :).
Comment 4 Abner Ballardo CLA 2010-02-24 17:09:33 EST
Created attachment 160130 [details]
Patch fixing bug

Hi everybody,

With this patch the task data directory field is editable. The validations after choosing the directory has been moved when clicking Apply or Ok buttons. Finally if the directory doesn't exists it will try to create it and its parents.
Comment 5 Abner Ballardo CLA 2010-02-24 17:09:36 EST
Created attachment 160131 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2010-02-24 17:37:41 EST
Thanks. I'll review later this week.
Comment 7 Steffen Pingel CLA 2010-02-25 23:12:05 EST
Great patch! I have applied with a minor simplification: checkForExistingTasklist() now returns false if the user cancels instead of storing the response in a field.
Comment 8 Steffen Pingel CLA 2010-03-29 16:26:48 EDT
Noticed a problem when the following steps are executed:
1. Import preferences that include task directory setting
2. Use Restore Defaults on Tasks preferences page

This fails with an error that the directory does not exist. The directory should be automatically created instead.
Comment 9 Steffen Pingel CLA 2010-04-03 02:23:58 EDT
Can not reproduce. The workspace directory may have had the wrong permissions.