Bug 27589 - [Editor management] Comment and two bugs?
Summary: [Editor management] Comment and two bugs?
Status: CLOSED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-12-03 11:43 EST by Sebastian Davids CLA
Modified: 2003-06-22 06:58 EDT (History)
1 user (show)

See Also:


Attachments
showing the extra space, missing V-Button and missing < > buttons (122.92 KB, image/jpeg)
2002-12-03 11:45 EST, Sebastian Davids CLA
no flags Details
showing the difference w/ < > buttons (111.50 KB, image/jpeg)
2002-12-03 11:56 EST, Sebastian Davids CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sebastian Davids CLA 2002-12-03 11:43:47 EST
Comment on Editors view:

The view should have a "V"-Button on its action bar w/ "Show Full Names",
"Sort", "Show Editors from..." to be consistent w/ the other views.

Under "Show Editors from..."there would be: "All Windows" and "Current Window"

Under "Sort" there would be "by Name" and "by Most Recently Used".

Consistency:

Tasks view uses "&Sort" and each entry prefixed w/ "by" ... so either adopt it
in Editors view or change Tasks view to use "Sort &by" (preferred).

A pushbutton for "Show Full Names" would be convenient.

What about a menu item "Show in New Window"? -- Or "Open in Perspective ..."

Comment on Tabs:

I find it inconvenient to click on a tab and than move the mouse all over to the
right side to click on "x" there -- having an "x" on each tab is more convenient
IMO.

Without the "x" the active label looks a little weird because of its gradient fill.

Bug:

If you have lots of Editors open and have a maximized Window the "<"/">"-buttons
are not shown under certain circumstances (doesn't happen when window is not
maximized).

There is an extra space right of the scrollbar, is this intended?

See attached screenshot.

@@@@

Nice work guys! -- Way better than the clumsy dialog.
Comment 1 Sebastian Davids CLA 2002-12-03 11:45:06 EST
Created attachment 2626 [details]
showing the extra space, missing V-Button and missing < > buttons
Comment 2 Sebastian Davids CLA 2002-12-03 11:56:15 EST
Created attachment 2628 [details]
showing the difference w/ < > buttons
Comment 3 Andrew Irvine CLA 2002-12-03 12:47:26 EST
You can ctrl-click on a specific tab to close it.
You can change the amount of tab compression on the editors preference page 
(windows>preferences>workbench>editors).

The extra space right of the scrollbar, is not intended.
The <> arrows do not show up until they are required.  I will verify the 
algorithm calculating the size of the <> buttons (and two new images) is 
correct.

The view is work in progress, your comments are appreciated.
Comment 4 Andrew Irvine CLA 2002-12-03 13:19:42 EST
The 'extra space' beside the right scroll bar is the 'overview ruler'.  It can 
be turned off by the preference page 
windows>preferences>java>editor>appearance>show overview ruler

It has been active for a while.  You may have noticed it when you have a 
compile error in the file, this ruler allows you to move quickly to the next 
compile error.
Comment 5 Sebastian Davids CLA 2002-12-03 15:21:31 EST
{rotfl} I'm using it all the time :)
Comment 6 Sebastian Davids CLA 2002-12-03 15:23:31 EST
The Ctrl + click to close the tabs is great too ... but unfortunately there is
no hint.

I wonder how other users will find out about it ...
Comment 7 Sebastian Davids CLA 2002-12-03 16:20:04 EST
The < > only vanish when you set compression to high.
Comment 8 Sebastian Davids CLA 2002-12-03 16:21:52 EST
Also:

If you click on a compressed tab at the right the tabs should be scrolled so
that the complete tab is visible.
Comment 9 Andrew Irvine CLA 2002-12-03 16:50:57 EST
In reference to comment #7
I have no issues with the left/right scroll appearing/disappearing with the 
various compression settings.  Then scrolls are only enabled if required.  
Perhaps the set of editors you are using is not sufficient to illustrate the 
problem.  I tried it with 30 editors open, the scrolling was fine.

In reference to comment #8
bug #27167 has been raised to look at this issue.
Comment 10 David Wegener CLA 2002-12-05 15:30:59 EST
I really hope that these changes are a mistake.  I have very few problems with 
the current editor management and don't want to loose the features of the 'X' 
being on each tab.  My preferences set the number of open editors to a low 
value of 5-6 depending on what will fit on the screen without scrolling and 
scrunching.  This provides what I consider to be a manageable number of open 
editors.  Combined with the new navigation history features, I am able to 
quickly bounce back and forth between the elements I need to work with.

I really like being able to close the tabs by simpling mousing over the 'X' and 
closing.  I don't want to have to hold down the CTRL key to do this.  It also 
doesn't logically fit.  Normally holding CTRL allows for multiple selections.  
Other editor enhancements deal with selecting multiple editors and performing 
an action on all of them - close, save, etc.  Given those changes, I would 
expect that holding CTRL and clicking on editor tabs would select multiple 
editors not close each one clicked.


The positioning of the new 'X' at the end of the editor tabs is a poor place to 
put it.  Please scrap it and put it back on the individual tabs.

I am ok with the drop down arrow to bring up the editor list and the side to 
side (< >) arrows for scrolling through the tabs.  These really wouldn't effect 
my prefered way of dealing with editors.  I have never used the current editor 
list other than out of curiosity after reading about it in the news group.  And 
the <> arrows appear to only show up if you exceede the number of tabs that can 
fit on the screen.

I love Eclipse.  Please don't make it difficult to use.
Comment 11 Andrew Irvine CLA 2002-12-12 16:43:07 EST
Eclipse 20021213

The closebox (X) has been put back on the individual tabs, and removed from the 
far right of the tab area.  In addition the pulldown menu has been made 
optional, the default is off (traditional behaviour).  To change the default 
values go to Window>Preferences>Workbench>Editors

The view was meant to have the same look & feel as the dropDown list.  Lowering 
the serverity of this PR to keep track of view suggestions/enhancements. 

The other issues raised in the bug have been addressed.
Comment 12 Kevin Haaland CLA 2003-02-07 17:02:35 EST
There are no plans for the UI team to work on this defect until higher priority 
items are addressed.  If you would like to work on a fix for this enhancement, 
please let us know on the platform-ui-dev mailing list.
Comment 13 Sebastian Davids CLA 2003-06-22 06:57:31 EDT
Nothing has survived from the new editor managing :/

I liked the drop-down box :)

Marking closed bug is obsolete.
Comment 14 Sebastian Davids CLA 2003-06-22 06:58:05 EDT
Ment:

Closing bug as it is obsolete =D