Bug 275743 - [About] [doc] Doc Only - installationPages schema file has extra colon
Summary: [About] [doc] Doc Only - installationPages schema file has extra colon
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 RC4   Edit
Assignee: Susan McCourt CLA
QA Contact: Susan McCourt CLA
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2009-05-11 19:14 EDT by Remy Suen CLA
Modified: 2009-06-03 18:43 EDT (History)
0 users

See Also:

Attachments
installationPages schema file patch v1 (899 bytes, patch)
2009-05-11 19:14 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2009-05-11 19:14:43 EDT 
Created attachment 135239 [details]
installationPages schema file patch v1

1. Open up a MANIFEST.MF file.
2. Go to the 'Extensions' tab.
3. Click the 'Add...' button.
4. Select the org.eclipse.ui.installationPages extension point.
5. Click 'Finish'.
6. In the created element, look at the 'class' attribute, you will see something like "whatever.InstallationPage:1".

Ideally, PDE should warn about this, I'll file a separate bug later.
Comment 1 Susan McCourt CLA 2009-05-12 10:58:14 EDT 
thx, Remy, I'll review/release.
Comment 2 Susan McCourt CLA 2009-05-13 12:53:11 EDT 
moving to RC4 as this is a doc bug.  
This bug also serves as a general review of the new about API.

Also:
Remy said in bug 275298:

Are clients supposed to implement IInstallationPageContainer? I think not...?
Will need @noimplement if that is the case.
Comment 3 Susan McCourt CLA 2009-06-02 13:37:44 EDT 
fixed in HEAD >20080602.
Note that the API tooling tag issue has been moved to its own bug in bug 278829 (because it is technically an API change and requires pmc approval after 3.5 M6).
Comment 4 Susan McCourt CLA 2009-06-02 13:43:59 EDT 
(In reply to comment #2)
> moving to RC4 as this is a doc bug.  
> This bug also serves as a general review of the new about API.

Note:  I reviewed both new API classes introduced in 3.5, InstallationPage and IInstallationPageContainer.

I fixed one typo (misspelling) in InstallationPage.
IInstallationPageContainer looks ok apart from the API tag issue in bug 278829.
Comment 5 Susan McCourt CLA 2009-06-03 18:43:36 EDT 
verified WinXP, Build id: I20090602-2000 through source inspection.