Community
Participate
Working Groups
Integrate the discovery mechanism by adding to the *Add Task Repository* wizard. At this point how this is to appear is uncertain. Likely to be either a hyperlink in the wizard UI, or an *Other...* kind added to the list of repository kinds available.
In order to avoid a hard-coded dependency from tasks.ui to discovery.ui we could try adding a toolbar to the wizard that is populated through IMenuService: menuService = (IMenuService) getSite().getService(IMenuService.class); menuService.populateContributionManager((ContributionManager) toolBarManager, "toolbar:org.eclipse.tasks.ui.toolbar.addrepository"); If that's too much overhead a dependency would also be okay for now but we should move the plug-ins out of the sandbox prior to doing that.
What I had in mind was integration with ICommandService. tasks.ui could look up a discovery ui command by its id, and the command could indicate if it's enabled. That would allow for greater flexibility in the ui. Agreed that we should try to avoid a plug-in dependency if possible.
Sounds good. I find toolbars a fairly flexible mechanism that gives contributions control over the UI (e.g. through ControlContributions) but go for whatever works.
Hyperlink 'download more connectors...' to go in *Add Task Repository* wizard.
Created attachment 134992 [details] candidate UI integration
Created attachment 134993 [details] mylyn/context/zip
Steffen can you please review the patch?
Created attachment 135043 [details] updated recut the patch: * avoid unnecessary activation of the discovery.ui bundle * display the wizard page for connector kind selection even if only one kind is currently available so that the user is presented with the hyperlink
Created attachment 135044 [details] mylyn/context/zip
Thanks David. I have applied the patch. I have also made a similar change to the query wizard to not skip the repository selection page if only one connector is installed to support discovery of the install ui.
(In reply to comment #10) > Thanks David. I have applied the patch. I have also made a similar change to the > query wizard to not skip the repository selection page if only one connector is > installed to support discovery of the install ui. Steffen, that's great... btw, though it's now integrated noone will see the link until bug 275224 is completed.
The setEnabled() method is not available in Eclipse 3.3: discoveryWizardCommand.setEnabled(createEvaluationContext(handlerService));
I have commented out the line that was breaking the build. David, please go ahead and commit a proper fix if you have one.
Thanks, fix in CVS
