Bug 275190 - [About] AboutTextManager focus and accessibility issues
Summary: [About] AboutTextManager focus and accessibility issues
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Oleg Besedin CLA
QA Contact: Susan McCourt CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-05-06 13:50 EDT by Susan McCourt CLA
Modified: 2011-02-02 15:09 EST (History)
1 user (show)

See Also:

Attachments
Doc pach (1.15 KB, patch)
2011-02-02 15:08 EST, Oleg Besedin CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2009-05-06 13:50:45 EDT 
Some issues originally raised in an accessibility review in bug #269079:

Help>About
> 1) After I open the dialog and press Tab focus shifts to somewhere where I
> can't see it.
Focus indicator not displaying in the about text manager text.

> 2) Two hyperlinks in the text are included in the tab order. Pressing "Enter"
> when either hyperlink is selected closes the dialog

Verified that the behavior is the same in 3.4.2.
Pressing "Enter" invokes the default button, which is close.
Pressing "Space" will activate the hyperlink.
This is implemented in AboutTextManager.  I'm not sure this is standard
behavior (we should see what native links do?)

> 5) On the "About Eclipse SDK Features" dialog there is an invisible focus
> position between the list of provides and hperlink (which, again, does nothing)

Also true in 3.4.2.  This is the custom link and key handling in
AboutTextManager
Comment 1 Susan McCourt CLA 2009-06-25 14:17:04 EDT 
assigning milestone for investigation in 3.6
Comment 2 Susan McCourt CLA 2009-10-06 17:41:41 EDT 
moving to M5 to reevaluate priority against other tasks.
Comment 3 Oleg Besedin CLA 2011-02-02 15:05:53 EST 
(In reply to comment #0)
> Some issues originally raised in an accessibility review in bug #269079:
> 
> > 1) After I open the dialog and press Tab focus shifts to somewhere where I
> > can't see it.
...
> > 5) On the "About Eclipse SDK Features" dialog there is an invisible focus
> > position...

Works for me in 3.7M5 - the cursor is visible at the end of respective text controls.
Comment 4 Oleg Besedin CLA 2011-02-02 15:07:58 EST 
(In reply to comment #0)
> > 2) Two hyperlinks in the text are included in the tab order. Pressing "Enter"
> > when either hyperlink is selected closes the dialog
> 
> Verified that the behavior is the same in 3.4.2.
> Pressing "Enter" invokes the default button, which is close.
> Pressing "Space" will activate the hyperlink.
> This is implemented in AboutTextManager.  I'm not sure this is standard
> behavior (we should see what native links do?)
> 

This seems to be the case throught Eclipse - links on Preferences pages and Launch configuration follow the same pattern. 

I did not know about using the "space" key to active links, so I'll add this bit to the Eclipse doc.
Comment 5 Oleg Besedin CLA 2011-02-02 15:08:35 EST 
Created attachment 188186 [details]
Doc pach
Comment 6 Oleg Besedin CLA 2011-02-02 15:09:36 EST 
Change to the Doc released to CVS Head; marking bug as "Works for me".