Bug 275018 - [Markers] Problems View / Configure Contents dialog should support rename
Summary: [Markers] Problems View / Configure Contents dialog should support rename
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M2   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Hitesh CLA
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2009-05-05 12:26 EDT by Kevin McGuire CLA
Modified: 2009-09-08 14:47 EDT (History)
6 users (show)

See Also:


Attachments
Patch v01 (7.55 KB, text/plain)
2009-09-04 09:43 EDT, Hitesh CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2009-05-05 12:26:41 EDT
This is a follow on to bug #257956 which was closed as fixed. The solution was to provide a "Duplicate" button to allow configs to be dup'd then edited.

This works ok but it does not remove the need for rename, which was part of the original request.  Consider:

1) If I create a new config or duplicate an existing, the only opportunity I get for naming it is at that exact moment.  Thereafter, I cannot rename configs that *I* made.  So I'm stuck with "New Filter" forever.  This makes the name useless in practice.

2) As with the requester of bug #257956, I don't understand the issues around rename of the existing configs, given I can edit all other aspects.  More to the point, I can make changes to the config such that it's behaviour *no longer matches* it's description/name.  For examples, "Errors/Warnings on Projects" can have the scope changed to be on any element, etc.  Thus we've opened the door so the user can make some changes, but not others, resulting in confusion.

Because of (1), which creates a situation the user cannot fix except through duplication/deletion, and (2), whereby the user can create a situation of contradiction, this is being logged as a usability bug and not an enhancement.
Comment 1 Kevin McGuire CLA 2009-05-06 11:51:47 EDT
Sorry I don't think this is an enhancement, it's a usability bug, see my last paragraph in comment #0.  

The fact I can modify a config so it no longer does what the name says, but I cannot rename it to match, creates a situation of confusion.  This then becomes a long term usability problem.
Comment 2 Boris Bokowski CLA 2009-05-06 12:15:25 EDT
(In reply to comment #1)
> Sorry I don't think this is an enhancement, it's a usability bug, see my last
> paragraph in comment #0.  

Sorry about that - when doing triage, I try to get away with spending a few seconds on each bug, which then leads to wrong bug classifications. At least the question whether or not this is an enhancement request has been discussed now. :-)
Comment 3 Boris Bokowski CLA 2009-05-06 12:16:51 EDT
(In reply to comment #2)
> ... which then leads to wrong bug classifications.

I meant to write "which then increases the chance of classifying a bug wrongly."

It is not my intention to get it wrong every time. ;-)
Comment 4 Robert Konigsberg CLA 2009-05-06 12:19:05 EDT
Personally I'd love seeing this listed as a bug. Thanks!
Comment 5 Kevin McGuire CLA 2009-05-08 11:01:51 EDT
(In reply to comment #4)
> Personally I'd love seeing this listed as a bug. Thanks!

Yup, I flipped it back to 'normal' from 'enhancement' in comment #1.
Comment 6 Hitesh CLA 2009-09-04 09:43:15 EDT
Created attachment 146499 [details]
Patch v01

Eric, could you please review the patch. (I'll raise a separate request for the celleditor stuff). Thanks.
Comment 7 Eric Moffatt CLA 2009-09-08 14:37:37 EDT
Commotted in >200909008. Applied the patch.

Hitesh, this is much better because of its simplicity. While the original decorated one was 'cool' it didn't fit with the rest of the UI (too cool..;-).

That being said you might start looking into what it would take to have the Control Decorations work with cell editors for the future. I'm surprised as well that we don't seem to have a validating text cell editor and I think that decorating the cell itself is a really good idea.
Comment 8 Eric Moffatt CLA 2009-09-08 14:38:46 EDT
Marking as fixed and setting the milestone.
Comment 9 Robert Konigsberg CLA 2009-09-08 14:47:56 EDT
I'm excited!!