Bug 275001 - Small rectangle is shown in editor
Summary: Small rectangle is shown in editor
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux-GTK
: P1 trivial (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-05-05 10:43 EDT by Anton Danilchenko CLA
Modified: 2020-05-14 11:09 EDT (History)
4 users (show)

See Also:


Attachments
In block comment (16.90 KB, image/png)
2009-05-05 10:45 EDT, Anton Danilchenko CLA
no flags Details
try ... catch mistake (44.42 KB, image/png)
2009-05-05 10:48 EDT, Anton Danilchenko CLA
no flags Details
Not highlighted symbol { (3.27 KB, image/png)
2009-05-05 10:53 EDT, Anton Danilchenko CLA
no flags Details
Into throw in if statement (28.80 KB, image/png)
2009-06-07 10:39 EDT, Anton Danilchenko CLA
no flags Details
patch (998 bytes, patch)
2010-02-25 19:43 EST, Zhongwei Zhao CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Danilchenko CLA 2009-05-05 10:43:34 EDT
Small marks in PHP editor (see atachements)
Comment 1 Anton Danilchenko CLA 2009-05-05 10:45:56 EDT
Created attachment 134437 [details]
In block comment

After * (where set input pointer) - not exist spaces
Comment 2 Anton Danilchenko CLA 2009-05-05 10:48:16 EDT
Created attachment 134438 [details]
try ... catch mistake

Set input pointer after keyword "catch"
Comment 3 Anton Danilchenko CLA 2009-05-05 10:53:20 EDT
Created attachment 134443 [details]
Not highlighted symbol {

Set input pointer after or before "}" - no effect.
If set input pointer after "{" - see highlighted symbol "}" - correctly
Comment 4 Michael Spector CLA 2009-06-07 04:18:27 EDT
Please report bug per issue. 
As for block comment and class body - I can't re-create them in latest PDT.
Comment 5 Anton Danilchenko CLA 2009-06-07 04:47:24 EDT
First attachement - In RC3 bug exists only in comment for class method (other block comments work correctly).
Second screensot - this bug maybe resolved (work correctly in RC3).
Third screenshot - bug exists in RC3. Not highlighted "{" symbol if set pointer after "}" symbol.

This bugs family I see in previous pdt 1.x and in latest builds pdt 2.x too.
Comment 6 Michael Spector CLA 2009-06-07 04:54:50 EDT
(In reply to comment #5)
> First attachement - In RC3 bug exists only in comment for class method (other
> block comments work correctly).
> Second screensot - this bug maybe resolved (work correctly in RC3).
> Third screenshot - bug exists in RC3. Not highlighted "{" symbol if set pointer
> after "}" symbol.
> 
> This bugs family I see in previous pdt 1.x and in latest builds pdt 2.x too.
> 

Would you split this bug into different bugs?
Comment 7 Anton Danilchenko CLA 2009-06-07 05:02:24 EDT
This a similar two bugs - incorrect highlight.
Comment 8 Anton Danilchenko CLA 2009-06-07 10:39:07 EDT
Created attachment 138509 [details]
Into throw in if statement
Comment 9 Anton Danilchenko CLA 2009-07-27 10:28:18 EDT
Fixed?
Comment 10 Zhongwei Zhao CLA 2010-02-25 19:43:29 EST
Created attachment 160261 [details]
patch
Comment 11 Q.S. Wang CLA 2010-03-09 06:22:48 EST
The 
try{}
catch{}
case is failed. 

You didn't check the '\t' character.

Please refine the patch. Thanks!
Comment 12 Q.S. Wang CLA 2010-03-10 19:13:15 EST
Applied the patch. Thanks
Comment 13 Gadi Goldbarg CLA 2010-05-03 10:08:03 EDT
Verified at PDT-2.2.0.v20100427 over Fedora Core 6 32bit
At first added screen shot see missing space at class method block comment - it works fine at this PDT
At second see mistake using try/catch block at highlighting - did not see it at this PDT
At third added screen shot see not selected matching bracket - it is works fine for this PDT
At fourth screen see error at highlighting at throw statement - did not see it at this PDT

Closing this issue...

Teodor Kirkov
teodor.k@zend.com