Community
Participate
Working Groups
I20090429-0100. I never want to loose my history and I never want to waste time on shutdown (or start up) to do any history pruning. Please add a preference to disable pruning entirely.
AFAIK, the long delay is not mainly spent for removing too old / too big histories, but to do garbage collection of unreferenced history entries. (In reply to bug 257167 comment #15) > Long-term, I think the garbage-collection approach just doesn't scale. Bug > 55182 comment 19 has a long analysis of this problem and possible solutions. > That bug also references bug 66370 and bug 66371 for possible improvements.
I'd like to see this sooner than later: each time I have to click the 'Cancel' button on shutdown. A fix should be pretty simple.
Dani, do you think with the switch set also "Maximum file size" should be ignored? It controls the maximum size of an entry in the history.
>Dani, do you think with the switch set also "Maximum file size" should be >ignored? It controls the maximum size of an entry in the history. Only if it affects the performance on shutdown, otherwise I'd like to be able to specify it.
Created attachment 149134 [details] Patch_v01 (In reply to comment #2) > A fix should be pretty simple. I won't take it that seriously next time ;)
(In reply to comment #1) > AFAIK, the long delay is not mainly spent for removing too old / too big > histories, but to do garbage collection of unreferenced history entries. If you don't apply the policy for limiting history size the unreferenced entries are collected before shutdown, during operations like project deletion. During the shutdown BLOBs corresponding to these entries are removed but no history tree traversal is needed in such case.
At first glance the fix looks good. I'll look at it again on Monday.
Created attachment 149363 [details] Patch_v02 Minor update.
Released to HEAD with some fixes in javadoc and code.
Pawel, please open a bug to update help for the local history preferences page and take care of it.
(In reply to comment #10) > Pawel, please open a bug to update help for the local history preferences page > and take care of it. Done, it's bug 292231.
Verified in I20091027-0100.
*** Bug 357267 has been marked as a duplicate of this bug. ***
I can see following code in current source: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java?id=7c3c71d443976edfcab48111f7939535acc8043a#n453 if (applyPolicy) monitor = new CancelableProgressMonitorWrapper( monitor, p); status.merge(((Workspace) ResourcesPlugin .getWorkspace()).save(true, true, monitor)); it looks like applyPolicy is largely ignored and only controls progress monitor wrapping. Could anyone confirm this was intended? This was found when working on bug 501404
(In reply to Vasili Gulevich from comment #14) > I can see following code in current source: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/bundles/org.eclipse.ui.ide.application/src/org/eclipse/ui/internal/ide/application/IDEWorkbenchAdvisor.java?id=7c3c71d443976edfcab48111f7939535acc8043a#n453 > > > if (applyPolicy) > monitor = new CancelableProgressMonitorWrapper( > monitor, p); > > status.merge(((Workspace) ResourcesPlugin > .getWorkspace()).save(true, true, monitor)); > > it looks like applyPolicy is largely ignored and only controls progress > monitor wrapping. > > > Could anyone confirm this was intended? > > > This was found when working on bug 501404 This seems not related to this bug here. Also, please do not reopen resolved bugs, but file a new one. Thanks.
