Bug 274212 - [target] Update button in the target provisioner
Summary: [target] Update button in the target provisioner
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement with 2 votes (vote)
Target Milestone: 3.7 M4   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
: 235420 (view as bug list)
Depends on: 287619
Blocks: 329553
  Show dependency tree
 
Reported: 2009-04-28 20:34 EDT by Pascal Rapicault CLA
Modified: 2010-12-08 15:55 EST (History)
9 users (show)

See Also:


Attachments
initial patch to update targets (13.27 KB, patch)
2010-10-25 17:08 EDT, Jeff McAffer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2009-04-28 20:34:39 EDT
I must admit that I like the new target provisioner. Now that it is so slick and easy to download things that the only thing that I wish was there is a "check for update" button. This way it becomes super trivial to keep the target up-to-date as well.
Remember there is almost everything in p2 to do this (hint, hint)
Comment 1 Curtis Windatt CLA 2009-04-29 09:56:54 EDT
Would be slick, though might be hard to fit it nicely into the UI as many targets do not use p2 and cannot be updated.  Will consider for 3.5, but no promises.
Comment 2 Chris Aniszczyk CLA 2009-04-29 10:17:50 EDT
Couldn't we do this via the set target operation? If there's nothing in the bundle pool, we know it's not an update.
Comment 3 Darin Wright CLA 2009-04-29 11:06:12 EDT
(In reply to comment #2)
> Couldn't we do this via the set target operation? If there's nothing in the
> bundle pool, we know it's not an update.

This is a feature request to "check for updates" to a target definition. I.e. if it comes from a repo, see if there is a newer version. Just like you would do to your running host. The question is how to fit this into the UI nicely.

Comment 4 Darin Wright CLA 2009-05-01 10:34:16 EDT
Nice, but this is a new feature so we must defer to 3.6
Comment 5 Eike Stepper CLA 2009-05-23 05:29:23 EDT
I'm also eagerly waiting for this feature (although I don't care in which release it will be).

Will automatic update also be included in this feature or should I open a separate bug?
Comment 6 Curtis Windatt CLA 2010-01-28 15:18:47 EST
This would be easier if targets were profile based (Bug 287619).
Comment 7 Jeff McAffer CLA 2010-10-25 17:08:15 EDT
Created attachment 181680 [details]
initial patch to update targets

This is a first cut at updating a target.  there is an Update button in the TargetLocationsGroup that calls an UpdateTargetJob. This simply scans through all IUBundleContainers looking for any feature and then looks for the most recent version of that feature. That new version is then used.  If the feature being updated is the current one then we automatically call LoadTargetDefinition.  

Issues:
- UI integration is rough.  The dirty flags and workflow need better integration
- Not clear that we want to automatically update the current target.  Could be expensive (causes a build) and there may be other edits or review to be done by the user.  flipside is that one button update makes it real "slick".
- might consider showing the user what is going to change (deluxe)
- Note that updating may cause a version drop if the latest things are not available
- likely some robustness topics if things are missing etc
- Affordances for 0.0.0 in the .target file are there but complicate things a tad.  If we are not going to really support that then the code can be simplified a bit.
Comment 8 Jeff McAffer CLA 2010-11-01 21:04:01 EDT
A slightly updated version of this patch has been consolidated with several other overlapping patches and attached to bug 328929.  discussion of issues related to this enhancement should continue here.  The consolidated patch is just to ease application.
Comment 9 Jeff McAffer CLA 2010-11-03 14:43:14 EDT
*** Bug 235420 has been marked as a duplicate of this bug. ***
Comment 10 Curtis Windatt CLA 2010-11-05 12:07:43 EDT
Fixed in HEAD.  Thanks for all the great work Jeff!
Comment 11 Curtis Windatt CLA 2010-12-08 15:55:33 EST
Verified in I20101208-0800

Still would be great to have people try out their own use cases to make sure this works well for them.