Bug 273634 - [Accessibility] Various Problems with mnemonics/accelerators in Profile Configuration window
Summary: [Accessibility] Various Problems with mnemonics/accelerators in Profile Confi...
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2009-04-24 15:24 EDT by Joshua Bowles CLA
Modified: 2016-05-05 10:59 EDT (History)
4 users (show)

See Also:


Attachments
Fixes up the mnemonics (7.68 KB, patch)
2010-04-26 11:36 EDT, Mike Reid CLA
no flags Details | Diff
Revised patch (10.17 KB, patch)
2010-05-07 15:03 EDT, Mike Reid CLA
no flags Details | Diff
Patch2 (2.49 KB, patch)
2010-09-28 10:51 EDT, Mike Reid CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bowles CLA 2009-04-24 15:24:26 EDT
Steps To Reproduce:
In the Profile Configuration window there are various problem with the mnemonics/accelerators for the various types of profile.  The problems are in 3 categories
1: Mnemonics are present but do not work
2: Mnemonics are present but have no purpose (i.e. for a read-only text field.
3: Mnemonics are "doubled up" (example. under common, H is used as an accelerator for both the "shared file" field and the Host tab.)
Comment 1 Kathy Chan CLA 2009-04-28 10:36:20 EDT
The workaround is to use tabs and arrow keys to move to the desire entries rather than relying on the Mnemonics.
Comment 2 Kathy Chan CLA 2009-08-07 10:58:47 EDT
Deferring to TPTP 4.6.2.
Comment 3 Kathy Chan CLA 2009-12-02 19:20:40 EST
Deferring to TPTP 4.7.0.
Comment 4 Mike Reid CLA 2010-04-26 11:36:36 EDT
Created attachment 166092 [details]
Fixes up the mnemonics

Attached patch fixes up the mnemonics mentioned herein so that all of the profiling configuration panels are navigable with keyboard accelerators.
Comment 5 Sean Lamers CLA 2010-04-30 09:29:59 EDT
Patch looks good.
Comment 6 Mike Reid CLA 2010-05-07 15:03:42 EDT
Created attachment 167539 [details]
Revised patch

Attached updated patch with updated copyright notices.
Comment 7 Jonathan West CLA 2010-05-07 15:12:01 EDT
Patch checked into HEAD.
Comment 8 Sean Lamers CLA 2010-06-11 17:01:53 EDT
I noticed there are still some problems with mnemonics in the TPTP-4.7.0-201006081927 build. Specifically, I found two conflicts:

1) In the "Host" tab of an "Attach to Agent" configuration, the letter "A" is used for both the "Add" button and the "Agents" tab.

2) In the "Environment" tab of an "External Java Application" configuration, and also in the "Parameters" tab of a "Java Applet" configuration, the letter "o" is used for the "Remove" button; this conflicts with the letter "o" for the "Monitor" tab. The solution to this would be to change the mnemonic for the tab (the letter "m" should probably be avoided though since it is also sometimes used for the "Remove" option in other views).
Comment 9 Joel Cayne CLA 2010-06-14 10:39:05 EDT
Reopening based on comment 8.
Comment 10 Kathy Chan CLA 2010-08-24 11:16:16 EDT
Deferring to TPTP 4.7.2.
Comment 11 Mike Reid CLA 2010-09-28 10:51:02 EDT
Created attachment 179753 [details]
Patch2

Attaching patch which fixes up these remaining problems. Note the conflict with o of "Monitor" tab no longer occurs because the monitor tab is renamed "Profile settings" in 4.7.1.
Comment 12 Kathy Chan CLA 2011-03-23 16:49:33 EDT
Since the patch solves some problem but might introduce some other conflects, we won't be proceeding with the patch.  The user can always get to the buttons by using tabs (rather than the mnemonics).  

Resolving as won't fix.
Comment 13 Mike Reid CLA 2011-04-04 10:59:02 EDT
Closing.