Bug 2736 - Performance: Task list delta listener should use visitor (1GITCP0)
Summary: Performance: Task list delta listener should use visitor (1GITCP0)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nick Edgar CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 5149 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-10 22:42 EDT by John Arthorne CLA
Modified: 2002-04-03 16:48 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2001-10-10 22:42:30 EDT 
TaskListContentProvider.getMarkerDeltas is a recursive method that walks over
tree deltas and gathers the set of marker changes.  We will soon be making some
optimizations to the delta visitor code, so it will soon be more efficient to use a visitor
than to walk over the delta yourself.  The visitor interface is IResourceDeltaVisitor, and
you would call accept() on the top level delta passed into TaskListContentProvider.resourceChanged.

NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 19:13:00 EST 
PRODUCT VERSION:

0.131
Comment 2 John Arthorne CLA 2002-02-04 17:29:56 EST 
Build 20020129

Your friends in core-land have now made this operation even easier!  You can now 
use IResourceChangeEvent#findMarkerDeltas to efficiently retrieve all the deltas 
you need.  Recursing over the delta is now no longer needed at all.

This is a simple optimization that is worth doing.
Comment 3 Nick Edgar CLA 2002-04-03 16:43:45 EST 
Now using the IResourceChangeEvent#findMarkerDeltas API.
Comment 4 Nick Edgar CLA 2002-04-03 16:43:58 EST 
Fixed
Comment 5 Nick Edgar CLA 2002-04-03 16:48:22 EST 
*** Bug 5149 has been marked as a duplicate of this bug. ***