Bug 273212 - Code changes are reverted when opening diff viewer
Summary: Code changes are reverted when opening diff viewer
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform Team Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 05:03 EDT by Marcel Billen CLA
Modified: 2019-09-06 16:18 EDT (History)
0 users

See Also:


Attachments
screenshots (213.40 KB, image/jpeg)
2009-06-25 02:09 EDT, Marcel Billen CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel Billen CLA 2009-04-22 05:03:38 EDT
I am using subclipse 1.2.4 for commiting source code changes into our local svn repository. 

In eclipse 3.5 M6 all my code changes are reverted when i try to review them in the diff viewer by doubleclicking the file in team->outgoing view. The file is marked by the star sign (unsaved changes) and no differences are displayed.
Comment 1 Marcel Billen CLA 2009-06-25 02:09:22 EDT
Created attachment 140063 [details]
screenshots
Comment 2 Marcel Billen CLA 2009-06-25 02:10:23 EDT
Since the problem still exists in version 3.5 final here's my testcase to reproduce the bug:

- Eclipse Galileo with Subclipse 1.2.4 installed
- Edit some versioned file in your working copy
- The file is marked by the brown star symbol (file changed)
- Open the synchronize-view
- Double-click the changed file in the synchronize-tree to open up the diff editor
- The file changes are reverted and the file is marked as unsaved!

Due to this bug it is impossible to update the source via subclipse since the same problem exists when trying to edit merge conflicts.
Comment 3 Tomasz Zarna CLA 2009-07-30 10:42:12 EDT
Marcel, this looks more like a Subclipse issue to me. Have you informed the provider of the plug-in about this?
Comment 4 Marcel Billen CLA 2009-08-24 01:26:23 EDT
No, I have not informed the provider yet, because everyting was fine with eclipse 3.4.2. Have there been any changes in the team api in version 3.5?
Comment 5 Tomasz Zarna CLA 2009-08-24 06:22:02 EDT
All breaking changes in the API are documented in the Migration Guide[1]. The only change made in the Team API is related to illegal use of internal types[2].

Are you saying that *the same* version of subclipse (ie 1.4.2) works differently on Eclipse 3.4.2 and 3.5M6? If so, it does look like our fault, but I would file a bug against Subclipse at the same time, just to see what they have to say about it.

[1] http://help.eclipse.org/stable/topic/org.eclipse.platform.doc.isv/porting/eclipse_3_5_porting_guide.html
[2] http://help.eclipse.org/stable/topic/org.eclipse.platform.doc.isv/porting/3.5/incompatibilities.html#teamPluginLeaks
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:18:56 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.