Bug 273203 - [Compare] Can't toggle breakpoints in java compare editor
Summary: [Compare] Can't toggle breakpoints in java compare editor
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-22 04:05 EDT by Pawel Pogorzelski CLA
Modified: 2019-09-06 15:36 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2009-04-22 04:05:06 EDT
Build ID: N20090419-2000

It would be useful because I often want to debug changes that I'm inspecting in the compare editor.
Comment 1 Dani Megert CLA 2009-04-22 04:10:25 EDT
Could be useful. Moving to compare: they first have to decide in general whether we want to start showing the vertical ruler. What about the overview ruler then?
Comment 2 Tomasz Zarna CLA 2009-04-22 04:26:38 EDT
I agree that showing the vertical ruler is the way to go. I guess this would allow us to show more than just breakpoints. We could display annotations, tasks etc. One thing I'm not so sure about is the "folding" ruler, don't know if this should be available while comparing.

Regarding the overview ruler, I think we could use it as well but it should filter out any non-compare annotations by default.

btw, with both rulers added we would be pretty close to use more of an embedded editor UI than we do so far. See bug 271787, comment 9 and 10, about calling createPartControl(Composite) method of an embedded editor, not just extracting a source viewer from it.
Comment 3 Michael Valenta CLA 2009-04-22 07:16:23 EDT
I think we need to keep in mind that screen real-estate can be tight when using the compare editor. It would be good if the user can hide the ruler if they prefer to use that real-estate for comparing.
Comment 4 Szymon Brandys CLA 2009-04-22 07:45:26 EDT
Before we start adding rules and other useful things, I would ask UI whether they plan further work during 3.6 on embedded editors/parts. 

I think that it would be great if we could just use editors inside of "compare container" instead of creating similar flow for creating, configuring and removing editors in the compare framework.
Comment 5 Dani Megert CLA 2009-04-22 07:47:26 EDT
> I would ask UI whether
>they plan further work during 3.6 on embedded editors/parts.
AFAIK this is deferred to e4.
Comment 6 Eclipse Webmaster CLA 2019-09-06 15:36:38 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.