Bug 272291 - [compare] 'Compare With' menu entries not intuitive
Summary: [compare] 'Compare With' menu entries not intuitive
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.3 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard: fix candidate
Keywords:
Depends on:
Blocks:
 
Reported: 2009-04-15 06:59 EDT by Dani Megert CLA
Modified: 2013-04-16 09:29 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-04-15 06:59:03 EDT 
I20090414-0800.

The following two 'Compare With' menu entries are not intuitive:

1) Other Element...
- this action compares the selected elements with each other in a compare
  dialog that does not offer structure compare (see bug 75601)
  ==> 'Each Other...' would be a better name here
- also, the name rather suggests that I can select one element and then a dialog
  allows me to select some other element to compare with (during 3.5 Compare
  offered such a feature but took it out again, see bug 264498)

2) Each Other
- this action does not compare the selected elements with each other but instead compares the files of each selected element with each other in a compare editor
  ==> 'Each Others Files' might be a better choice
- users selecting e.g. two methods or fields would expect to use 'Each Other' but it's not available. Instead they have to use 'Other Element...'
Comment 1 Dani Megert CLA 2009-04-15 07:00:50 EDT 
Marking as potential 3.6 candidate. Changing this should be done early in the release cycle.
Comment 2 Dani Megert CLA 2013-04-16 09:29:56 EDT 
For 2) "Each Other" is OK and actually better than "Each Others Files".

To avoid the confusion, I've renamed "Other Element..." to "Each Other by Member".

Fixed with http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=f1dd40f5c635ffcfaebaac6aaf51a564f2d6299a