Bug 272279 - Add PHP Default PHPPartitionType to PHPStructuredTextPartitioner
Summary: Add PHP Default PHPPartitionType to PHPStructuredTextPartitioner
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2009-04-15 05:54 EDT by Q.S. Wang CLA
Modified: 2020-05-14 11:28 EDT (History)
4 users (show)

See Also:

Attachments
The patch (1.50 KB, patch)
2009-04-15 05:55 EDT, Q.S. Wang CLA 		no flags Details | Diff
New patch (1.63 KB, patch)
2009-04-16 03:29 EDT, Q.S. Wang CLA 		jacek.pospychala: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Q.S. Wang CLA 2009-04-15 05:54:10 EDT 
Build ID: 3.5 M5

Steps To Reproduce:
The "org.eclipse.php.PHP_DEFAULT" should be added as the supported type of PHPStructuredTextPartitioner

More information:
Comment 1 Q.S. Wang CLA 2009-04-15 05:55:34 EDT 
Created attachment 131903 [details]
The patch
Comment 2 Roy Ganor CLA 2009-04-15 08:27:52 EDT 
don't you think that we should extend getConfiguredContentTypes() instead?

this can be done by getting the super.getConfiguredContentTypes()
and then cretae a new array that includes these values and the addition of the PHP default.

Thoughts?
Comment 3 Q.S. Wang CLA 2009-04-15 21:06:45 EDT 
Overwrite the getConfiguredContentTypes method is my init idea, however the fSupportedTypes field is protected. So it can be a risk, if any sub class code access the fSupportedTypes directly instead of using get method. Comments?
Comment 4 Roy Ganor CLA 2009-04-16 03:04:23 EDT 
my suggestions:

protected void initLegalContentTypes() {
		super.initLegalContentTypes();

		// add a new values and then add it to the fSupportedTypes 
}
Comment 5 Q.S. Wang CLA 2009-04-16 03:29:59 EDT 
Created attachment 132027 [details]
New patch
Comment 6 Roy Ganor CLA 2009-04-16 03:44:55 EDT 
committed to HEAD.

contributed by Qiangsheng.

thanks!
Comment 7 Q.S. Wang CLA 2009-04-16 04:00:58 EDT 
closed