Bug 271585 - [ui] Can't rename available software sites
Summary: [ui] Can't rename available software sites
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
: 233180 266592 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-08 05:06 EDT by Robert Konigsberg CLA
Modified: 2009-06-09 17:10 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Konigsberg CLA 2009-04-08 05:06:19 EDT
Let's say I attempt to add a software site using the Available Software dialog. I enter an URL and press Enter. Then I click the "Available Software Sites" button and see that my site is listed there, hey! But now I want to give the site a name. Why can't I? Feature request, please.
Comment 1 John Arthorne CLA 2009-04-08 10:53:06 EDT
What build are you using? This works from me in I20090401 - I just click on the name in the table on the "Available Software Sites" preference page.
Comment 2 Robert Konigsberg CLA 2009-04-08 10:57:21 EDT
Hi John. I'm pretty sure I was using 3.5M6.

Oh.. I see that now. Erm, that's not particularly intuitive. Particularly since I can't do the same thing with the URL or enabled columns, and there is no visual distinction between them to indicate that they're editable.

Given that there's plenty of room on the right side button bar for one more button, would you add one for Edit...?

Oh and I'm going to catch hell for asking this in the same bug, but a) why can't I edit the URL and b) can the result of the Test Connection button give some sort of affirmation if the connect test passes?
Comment 3 Susan McCourt CLA 2009-04-09 11:15:06 EDT
marking for consideration for 3.5 polish bugs.
We have to come up with an accessible/keyboard way to do the edit, so some alternative should be provided.
Comment 4 Susan McCourt CLA 2009-04-20 18:01:24 EDT
Fixed in HEAD >20090420.  Given the accessibility issue (bug 269216) and this usability issue, I added an Edit button.  This also paves the way to provide a dialog that allows automatic URL correction when a site is not found (bug 269507).

This button falls underneath the add button, to keep it consistent with the edit button on the help content preferences.  I debated calling it Properties but it doesn't look like a properties dialog.  However in the spirit of "Properties" there is no ellipsis on "Edit" (not "Edit..."). 

> Oh and I'm going to catch hell for asking this in the same bug, but a) why
> can't I edit the URL and b) can the result of the Test Connection button give
> some sort of affirmation if the connect test passes?

Oh, ye of little faith.  ;-)
On a different day you might have caught hell, but today is my birthday, and it's a beautiful spring day, and I was in the dialog anyway, and I want to add URL editing to support bug 269507, and I've been meaning to add a test connection info dialog for some time now because local sites go by too fast.

So fixed, fixed, fixed.  

However I'm not going to provide automatic editing of the URL in the table cell itself because we don't have a good place to put the validation errors.  Or at least, I don't want to open that can of worms this late in the release.

Comment 5 Ian Bull CLA 2009-04-20 18:58:50 EDT
> On a different day you might have caught hell, but today is my birthday, and
> it's a beautiful spring day,

With the risk of going off topic: HAPPY BIRTHDAY SUSAN! :-)


Comment 6 Robert Konigsberg CLA 2009-04-20 20:16:15 EDT
(sing to Happy Birthday To You)
Happy Birthday To You,
I don't know who you are.
But in honor of your birthday,
I won't report another bug!

It's no They Might Be Giants, but what do you expect from a bug database?
Comment 7 Susan McCourt CLA 2009-04-21 01:23:52 EDT
(In reply to comment #6)
> (sing to Happy Birthday To You)
> Happy Birthday To You,
> I don't know who you are.
> But in honor of your birthday,
> I won't report another bug!
> 
> It's no They Might Be Giants, but what do you expect from a bug database?
> 

Hey, I appreciate the sentiment!
(And it's ok to keep reporting bugs...)
Comment 8 Susan McCourt CLA 2009-04-27 17:01:12 EDT
*** Bug 233180 has been marked as a duplicate of this bug. ***
Comment 9 Susan McCourt CLA 2009-06-09 17:10:48 EDT
*** Bug 266592 has been marked as a duplicate of this bug. ***