Bug 271416 - VersionNumberStripper fails with underscores in path
Summary: VersionNumberStripper fails with underscores in path
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 237588
  Show dependency tree
 
Reported: 2009-04-07 03:45 EDT by Nicolas Richeton CLA
Modified: 2009-06-01 09:54 EDT (History)
3 users (show)

See Also:

Attachments
Fix for underscores in path (1.66 KB, patch)
2009-04-08 03:16 EDT, Nicolas Richeton CLA 		john.arthorne: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Richeton CLA 2009-04-07 03:45:13 EDT 
The custom ant task VersionNumberStripper from org.eclipse.releng.basebuilder renames jars by looking for the first underscore in the ABSOLUTE path of each file. 

int underScorePos = files[i].getAbsolutePath().indexOf("_");
(files[i].getAbsolutePath()).substring(0, underScorePos)


If the path contains an underscore all jars are moved to one single jar. 

/home/nricheton/nebula_builds/build/technology/nebula/gallery/downloads/drops/0.5.0/N200904070926/eclipse/plugins/*.jar

->
 
/home/nricheton/nebula.jar

and that makes the build fail because all dependencies are missing

I'll attach a patch soon.
Comment 1 Nicolas Richeton CLA 2009-04-08 03:16:42 EDT 
Created attachment 131225 [details]
Fix for underscores in path
Comment 2 Kim Moir CLA 2009-04-08 14:47:11 EDT 
Thanks, I'll try out this patch when I run the next test build.
Comment 3 Kim Moir CLA 2009-04-13 11:19:20 EDT 
Released.
Comment 4 John Arthorne CLA 2009-06-01 09:54:22 EDT 
Removing iplog+ from bug - this indicates an IP contribution in a comment
rather than a patch.

http://wiki.eclipse.org/Development_Resources/Automatic_IP_Log