Community
Participate
Working Groups
Verifying results for build I20090331-0901, I see one failure in Platform/UI performance tests: Policy.getComparatorTest Failure Method "Policy.getComparatorTest" not found junit.framework.AssertionFailedError: Method "Policy.getComparatorTest" not found at junit.extensions.TestDecorator.basicRun(TestDecorator.java:24) at junit.extensions.TestSetup$1.protect(TestSetup.java:21) at junit.extensions.TestSetup.run(TestSetup.java:25) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:354) at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:206) at org.eclipse.test.UITestApplication$3.run(UITestApplication.java:195) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:133) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3457) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3104) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2393) at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2357) at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2209) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:499) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:492) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:113) at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:138) at org.eclipse.test.UITestApplication.run(UITestApplication.java:60) at org.eclipse.test.UITestApplication.start(UITestApplication.java:210) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:194) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:368) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:556) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:511) at org.eclipse.equinox.launcher.Main.run(Main.java:1284) at org.eclipse.equinox.launcher.Main.main(Main.java:1260) at org.eclipse.core.launcher.Main.main(Main.java:30)
Is this a new failure? AFAICT this is coming from: addTest(new CollatorPerformanceTest("Policy.getComparatorTest")); which has been checked in since Nov 26, 2008. (in HEAD and the perf_34x branch) It is a complete Test with a name, "Policy.getComparatorTest", and I'm not sure why we would get a: Method "Policy.getComparatorTest" not found PW
(In reply to comment #1) > Is this a new failure? AFAICT this is coming from: > addTest(new CollatorPerformanceTest("Policy.getComparatorTest")); > which has been checked in since Nov 26, 2008. (in HEAD and the perf_34x branch) > > It is a complete Test with a name, "Policy.getComparatorTest", and I'm not sure > why we would get a: Method "Policy.getComparatorTest" not found > > PW > No, it happened since 3.5 perf results day 1 (e.g. see M4 results: http://download.eclipse.org/eclipse/downloads/drops/S-3.5M4-200812111908/performance/html/org.eclipse.ui.tests.performance_linuxgtkperf2.html)
I think this test never worked as a part of the test suite. As Paul mentioned, it was added in November 2008. The M4 was done in December 2008. As would be expected, M4 included the change (originally submitted in bug 229782) and showed test failure. The test name should not be "Policy.getComparatorTest", but rather "testCollator". See the TestCase Javadoc: * The dynamic way uses reflection to implement <code>runTest</code>. It dynamically finds * and invokes a method. * In this case the name of the test case has to correspond to the test method * to be run.
Created attachment 131986 [details] Patch Changed test name, changed number of iterations to a more reasonable number. Note the bug 229782 comment 6: the change probably needs to be put in the CVS Head, perf34x, perf33x, and perf32x streams.
(In reply to comment #4) > Created an attachment (id=131986) [details] > Patch > > Changed test name, changed number of iterations to a more reasonable number. > > Note the bug 229782 comment 6: the change probably needs to be put in the CVS > Head, perf34x, perf33x, and perf32x streams. > Oleg, head and perf_34x will be enough. There's no longer perf tests in other streams... Is the patch going to be released before M7?
Oleg, are you handling this or were you wanting me to look at it first?
Fixed in HEAD and perf34x. Will update the map file in the perf34x stream as well.
Verified for M7 with I20090430-2300 results
