Bug 26988 - Help dialogs do not honour dialog font
Summary: Help dialogs do not honour dialog font
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Help-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 19346
  Show dependency tree
 
Reported: 2002-11-22 12:29 EST by Tod Creasey CLA
Modified: 2003-08-07 12:41 EDT (History)
1 user (show)

See Also:


Attachments
fixes (18.23 KB, patch)
2002-11-28 20:03 EST, Sebastian Davids CLA
no flags Details | Diff
fixes (13.78 KB, patch)
2002-11-28 21:03 EST, Sebastian Davids CLA
no flags Details | Diff
fix for "scope" in HelpSearchPage (748 bytes, patch)
2002-11-29 01:11 EST, Sebastian Davids CLA
no flags Details | Diff
TomcatPreferencePage (1.27 KB, patch)
2002-11-29 01:57 EST, Sebastian Davids CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tod Creasey CLA 2002-11-22 12:29:39 EST
20021115

The dialog font is not honoured by the Application server preference page. 
Preference pages have the dialog font set as the font of the control sent to 
createContents - you can just copy the font from the parent to the children 
you create. Other dialogs can get it by calling JFaceResources.getDialogFont().

This is also an issue for the About details pages.
Comment 1 Sebastian Davids CLA 2002-11-28 20:03:45 EST
Created attachment 2574 [details]
fixes

fixes:

HelpSearchPage
ContextHelpDialog
RuntimeErrorDialog
BrowsersPreferancePage
HelpWorkingSetPage
TomcatPreferancePage

@@@@

AboutFeaturesDialog
AboutPluginsDialog

both belong to org.eclipse.workbench -- I will supply a seperate patch
Comment 2 Dorian Birsan CLA 2002-11-28 20:43:05 EST
Sebastian, it looks like the attachment is for the Compare component.
Could you create another one for help? Thanks!
Comment 3 Sebastian Davids CLA 2002-11-28 21:03:44 EST
Created attachment 2575 [details]
fixes

grrr ;)
Comment 4 Sebastian Davids CLA 2002-11-28 21:04:43 EST
forgot to mark the other as obsolete :(
Comment 5 Dorian Birsan CLA 2002-11-28 22:04:14 EST
Fixes applied. Thanks for helping!
Comment 6 Sebastian Davids CLA 2002-11-29 01:11:51 EST
Created attachment 2577 [details]
fix for "scope" in HelpSearchPage
Comment 7 Sebastian Davids CLA 2002-11-29 01:57:08 EST
Created attachment 2579 [details]
TomcatPreferencePage

changed the fonts of the spacers but not the actual labels :(
Comment 8 Sebastian Davids CLA 2002-11-29 02:27:04 EST
attachment 2580 [details] fixes the About details pages
Comment 9 Dorian Birsan CLA 2002-11-29 09:34:07 EST
I let the spacer's font in, because it doesn't hurt.
The "About" pages are contributed by the UI team, so I did not make those 
changes.
Comment 10 Sebastian Davids CLA 2003-08-07 06:26:00 EDT
Help Search Page does not use the dialog font.
Comment 11 Konrad Kolosowski CLA 2003-08-07 10:32:19 EDT
Sebastian,
I do not get your last comment.  Do you see anything more that is wrong with 
the help search, or the fixes did not work?
Comment 12 Sebastian Davids CLA 2003-08-07 11:26:08 EDT
Search/Help...

Tab "Help Search"
Comment 13 Konrad Kolosowski CLA 2003-08-07 11:35:40 EDT
I do not see a problem.  Eclipse 2.1, changed preferences to use bold italic 
10 for dialog font.  Opened Search->Help from the menu.  All the fonts look as 
specified.
Comment 14 Sebastian Davids CLA 2003-08-07 12:25:03 EDT
Search/Search...

Take a look at the different tabs including the "Help Search" tab.

Close the dialog.

Window/Preferences/Workbench/Fonts

Change Dialog font ... different size for example.

Search/Search...

Take a look at the different tabs including the "Help Search" tab.

Observe:

The "Help Search" page is the only one *not* to pick up the font change
Comment 15 Konrad Kolosowski CLA 2003-08-07 12:41:03 EDT
I can reproduce following your steps.
This is a different problem than this bug.  The search page was not using 
dialog fonts.  This was fixed (follow my steps).
The problem is that if you open help search page first, then open change the 
fonts, the change does not take effect without restarting workbench.  It would 
be good if you opened a new bug for this (with your steps to reproduce).