Bug 269424 - [JFace] StringMatcher party - Make StringMatcher API?
Summary: [JFace] StringMatcher party - Make StringMatcher API?
Status: CLOSED DUPLICATE of bug 2382
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Susan McCourt CLA
URL:
Whiteboard:
Keywords:
: 280514 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-03-19 13:51 EDT by Susan McCourt CLA
Modified: 2009-11-02 12:01 EST (History)
8 users (show)

See Also:

Attachments
org.eclipse.jface.patch (12.27 KB, patch)
2009-03-19 17:36 EDT, Chris Aniszczyk CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2009-03-19 13:51:08 EDT 
I had to copy org.eclipse.ui.internal.misc.StringMatcher in p2 to provide wild card auto-complete in a wizard.

I noticed copies of the class in JDT, PDE, IDE, etc....

We should look at making this API, probably in JFace.
Then it could be used by the JFace field assist auto complete, as well as the dialogs.
Comment 1 Chris Aniszczyk CLA 2009-03-19 15:49:41 EDT 
I count at least 8 places that it's used. Since we are past API freeze, we would have to get PMC approval to get this in.
Comment 2 Susan McCourt CLA 2009-03-19 17:21:08 EDT 
I was assuming 3.6, no rush...
Comment 3 Chris Aniszczyk CLA 2009-03-19 17:22:40 EDT 
I would prefer 3.5 and the ability to reduce code is a good thing (tm).

What do you think?
Comment 4 Chris Aniszczyk CLA 2009-03-19 17:36:44 EDT 
Created attachment 129397 [details]
org.eclipse.jface.patch

A first stab at a patch based on the JDT implementation. There's some documentation to do still...
Comment 5 Susan McCourt CLA 2009-03-20 10:50:21 EDT 
thanks for the patch.
We have so many of these situations, I don't see treating StringMatcher as a special case and pushing this into 3.5 past API freeze.  To add any value, clients would have to switch to it, and then if there are behavior differences/bugs I've got RC bugs I don't need...
Comment 6 Susan McCourt CLA 2009-07-06 17:32:51 EDT 
*** Bug 280514 has been marked as a duplicate of this bug. ***
Comment 7 Ali Ok CLA 2009-07-22 07:44:22 EDT 
Added my self to CC.
Isn't there a more silent way of this?
Comment 8 Remy Suen CLA 2009-07-22 07:50:07 EDT 
(In reply to comment #7)
> Added my self to CC.
> Isn't there a more silent way of this?

Just use the 'Add CC:' field in the top right corner and type your email address there.
Comment 9 Dani Megert CLA 2009-11-02 06:18:50 EST 
This should be marked as duplicate of bug 2382 and bug 2382 be reopened.

Also note that UI is probably the wrong layer to add this API as some core plug-ins also maintain a copy of StringMatcher.
Comment 10 Susan McCourt CLA 2009-11-02 12:01:20 EST 
A four digit bug number.  Wow.  Marking duplicate

*** This bug has been marked as a duplicate of bug 2382 ***