Community
Participate
Working Groups
When creating multiple Plug-In Projects that need the same Plug-In Provider value it would be helpful if PDE would provide a combo box instead an edit field, that contains previously entered Plug-In Providers as a kind of history. It should select the most recent choosen one from the history list as default value.
cool, this sounds fair enough. How about a contribution and patch ;)?
Sure Chris, always happy to contribute. Can you give me a hint where I could save the history too? Which PreferenceStore are we using in PDE?
I believe we're already using dialog settings... can't you hitch a ride on those ;)? org.eclipse.pde.internal.ui.wizards.plugin.PluginContentPage.saveSettings(IDialogSettings) While you're at it, maybe you can fix the wizard so we don't say "Plug-in ID:" and just "ID:" :)
Sure that should be possible to change the label to "ID:" :) I will use the DialogSettings then. Sounds good. Maybe we could further enhance the dialog in a way that it would create the bundle localization automatically if you enter the plugin-name and provider with a beginning "%" notation. Like "%bundle.provider=company" And it would parse this and create the bundle localization at OSGI-INF/l10n/bundle.properties inserting the bundle.provider=company. If you enter "%bundle.provider" and ommit the value it will be a validation failure. But you could also always enter "company" only. But maybe thats another enhancement alltogether.
(In reply to comment #4) > Maybe we could further enhance the dialog in a way that it would create the > bundle localization automatically if you enter the plugin-name and provider > with a beginning "%" notation. Like "%bundle.provider=company" And it would > parse this and create the bundle localization at > OSGI-INF/l10n/bundle.properties inserting the bundle.provider=company. > If you enter "%bundle.provider" and ommit the value it will be a validation > failure. But you could also always enter "company" only. But maybe thats > another enhancement alltogether. > I think we already have a bug very similar, let me find it...
(In reply to comment #5) > I think we already have a bug very similar, let me find it... bug 222155 :) That's kind of funny since this patch is about exactly one year old since I remember very well working on it a few days before I took off to EclipseCon :p I think bug 222155 is exactly what you're asking in comment 3. Note that in the current implementation you'll find there, there is no way to indicate the keys you want to use when in the wizard (I mean: the vendor will always be stored under the bundle.vendor key of you l10n file,), thus no need to parse strings in the wizard. And that's much simpler for the end-user IMHO.
ok Benjamin I will take a look and maybe merge the two patches together.
Chris where is the PDE UI project located now in CVS? I can not find it a org.eclipse.pde.ui. The readme.txt says it has moved. But at the location specified there is no source code.
Nevermind, found it in /pde/ui/... In the HEAD there where 2 "pde" called folders with different symbols. So I can start working now.
Created attachment 129437 [details] Initial patch Adds history combo boxes to NewPluginProjectWizard,NewFragmentProjectWizard,NewFeatureProjectWizard and NewFeaturePatchProjectWizard
Created attachment 129438 [details] mylyn/context/zip
It seems like the NewPluginProjectWizard was not saving the dialog settings of the main page so far. I have changed that. During the FragementPage construction the Wizard does not have any DialogSettings available, so I can not load the history. It works in FeaturePatch and Feature wizards though.
(In reply to comment #12) > It seems like the NewPluginProjectWizard was not saving the dialog settings of > the main page so far. I have changed that. > During the FragementPage construction the Wizard does not have any > DialogSettings available, so I can not load the history. > It works in FeaturePatch and Feature wizards though. > Did you have a look at what I did for bug 222155. In particular I can see that kind of piece of code in the patch: public NewFragmentProjectWizard() { setDefaultPageImageDescriptor(PDEPluginImages.DESC_NEWFRAGPRJ_WIZ); + setDialogSettings(PDEPlugin.getDefault().getDialogSettings()); and I think it is missing in your patch! :)
To be honest I have not checked the other bug. I will do that on Monday. Are there any other things you would recommend to include in this patch?
Created attachment 129469 [details] added DialogSettings to NewFragmentProjectWizard as recommended by Benjamin
Created attachment 129470 [details] mylyn/context/zip
will this make it into 3.6?
We should at least review the patch for M1.
Curtis, have time to look at this one? M1 is soon ;o
A couple things: 1) The combo doesn't save a blank entry, so if you no longer want a provider, the wizard always reset to the last entry. The combo should have an empty entry that can be chosen. 2) Are we sure we want to have the last entry automatically chosen? How many users are always going to want the same provider? I'm all for having a combo to quickly choose previous options, but my feeling is that it would be safer to leave the text blank.
It has been a while since I coded the patch. As far as I remember, the Combo allows you to enter text, so there is no need for an empty entry. Just don't select anything, or if you did just delete the text in the combo. As for your second point: This enhancement was born because I create like 20 bundles for my company and do not want to enter the provider again and again. Thats why I also decided to re-select the last selected provider entry when the wizard is opened again. It saves clicks. Maybe we could add a checkbox "Set as default provider" which causes the selected provider to be selected as default.
(In reply to comment #21) > It has been a while since I coded the patch. As far as I remember, the Combo > allows you to enter text, so there is no need for an empty entry. Just don't > select anything, or if you did just delete the text in the combo. > As for your second point: This enhancement was born because I create like 20 > bundles for my company and do not want to enter the provider again and again. > Thats why I also decided to re-select the last selected provider entry when the > wizard is opened again. It saves clicks. Maybe we could add a checkbox "Set as > default provider" which causes the selected provider to be selected as default. > The combo allows you to enter text, but if I delete the text, the value isn't saved. So if I don't want a provider, I'll have to delete the text every time. Adding checkbox will clutter up the wizard. I know that you are creating a large number of projects with the same provider. What I want to know is if other people are regularly changing providers, or set the value as a one off thing. Chris, you had originally suggested that this request was reasonable. Any ideas on how a majority of users interact with the field?
Not going in for M1.
Removing milestone. The current solution is not polished enough.
Will this bug every be resurrected? Typing in the long names of some of the companies I work for is a bind. I had thought could the provider come from a global default (something standard I can give to other developers in the team in a settings file).
(In reply to comment #25) > Will this bug every be resurrected? Typing in the long names of some of the > companies I work for is a bind. I had thought could the provider come from a > global default (something standard I can give to other developers in the team > in a settings file). This bug needs an updated patch for it to be fixed.
Created attachment 196643 [details] Updated patch Removed default selection of provider from combo
Created attachment 199614 [details] Cleaned up fix Attachment #196643 [details] had a lot of unrelated changes in it. I went through the patch, taking the actual changes then cleaned up the comments, copyrights and naming. This patch contains the result that will be applied to 3.8.
Applied the cleaned up fix to HEAD.
The drop down history is nice to have but I did notice that the actual OSGi header that gets filled in with the provider info is 'Bundle-Vendor'. Perhaps the UI should use the word 'Vendor' rather than 'Provider'?
(In reply to comment #30) > The drop down history is nice to have but I did notice that the actual OSGi > header that gets filled in with the provider info is 'Bundle-Vendor'. Perhaps > the UI should use the word 'Vendor' rather than 'Provider'? Fixed in HEAD. We now call it Vendor everywhere. We'll have to update the doc in 3.8, created byg 353358 for it. This change makes a lot of sense for plug-ins. However, in feature.xml it gets a little weird because the file uses provider instead of vendor. I don't want to change the syntax of the xml, but I changed the UI. Only changes were in pderesources.properties from pde ui.
Verified with I20110802-2000
