Bug 269383 - Compiler warnings in N20090318-2000
Summary: Compiler warnings in N20090318-2000
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: DJ Houghton CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-19 10:42 EDT by Olivier Thomann CLA
Modified: 2009-03-31 17:10 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2009-03-19 10:42:09 EDT 
1. WARNING in /src/org/eclipse/swt/jmx/internal/SleakContributionProvider.java
 (at line 200)
Error[] oldErrors = new Error[0];
The field SleakContributionProvider.Sleak.oldErrors is never read locally

1. WARNING in /JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_BidiSegmentListener.java
 (at line 23)
import org.eclipse.swt.internal.BidiUtil;
The import org.eclipse.swt.internal.BidiUtil is never used
/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java : 1 warning :
OTHER WARNINGS 1. WARNING in /JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_StyledTextContent.java
 (at line 20)
import org.eclipse.swt.internal.BidiUtil;
The import org.eclipse.swt.internal.BidiUtil is never used
Comment 1 Felipe Heidrich CLA 2009-03-19 15:51:14 EDT 
Fixed the warnings in Jnit, but this SleakContributionProvider is not SWT.


please, re-route to the correct component.
Comment 2 Felipe Heidrich CLA 2009-03-23 11:26:27 EDT 
Kevin, do you know who owns SleakContributionProvider ?
Comment 3 Kevin Barnes CLA 2009-03-23 11:29:40 EDT 
I have no idea. 
Car, do you know where org.eclipse.swt.jmx.internal.SleakContributionProvider comes from?
Comment 4 Olivier Thomann CLA 2009-03-23 11:34:08 EDT 
Looking at the map file, it comes from there:
plugin@org.eclipse.swt.jmx=v20070510,:pserver:anonymous@dev.eclipse.org:/cvsroot/eclipse,,equinox-incubator/org.eclipse.swt.jmx
Comment 5 Olivier Thomann CLA 2009-03-23 11:37:40 EDT 
DJ seems to contribute the code to CVS.
Reassigning to him.
Comment 6 DJ Houghton CLA 2009-03-23 16:11:43 EDT 
I will fix this after bug 269726 is fixed to ensure that we are modifying the correct version of the files and so that the patch on the other bug will apply cleanly for Tom.
Comment 7 DJ Houghton CLA 2009-03-31 17:10:12 EDT 
Fixed.