Bug 269268 - [templates] Enhancements to template code
Summary: [templates] Enhancements to template code
Status: CLOSED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2009-03-18 15:18 EDT by Christine Rice CLA
Modified: 2009-03-20 11:43 EDT (History)
1 user (show)

See Also:

Attachments
Template code (20.90 KB, application/x-zip-compressed)
2009-03-18 15:18 EDT, Christine Rice CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christine Rice CLA 2009-03-18 15:18:37 EDT 
Created attachment 129271 [details]
Template code

IBM has used and extended classes from the org.eclipse.jface.text.templates and org.eclipse.jface.text.templates.persistence packages. Our major alteration involved updating the UpdateOrCreateVariable() method from TemplateTranslator to allow multiple "variable:name" mappings within a single template (for example, a template might have both ${attr:value} and ${attr:var}). Please see the attached zip for the files we changed.
Comment 1 Dani Megert CLA 2009-03-19 04:04:01 EDT 
Hi Christine, the attached ZIP does not contain any class that exists in Eclipse. Maybe you renamed/copied them? If you suggest changes to the existing code then you should make them directly in the Eclipse code base and attach a patch.
Comment 2 Christine Rice CLA 2009-03-19 10:36:25 EDT 
Yes, we did rename and copy some Eclipse classes.

This bugzilla was opened as an FYI. I just wanted to let Eclipse know about some changes that we had made to Eclipse code. I wasn't necessarily suggesting that you adopt any of these changes (we just made them for ourselves).

Thanks.
Comment 3 Dani Megert CLA 2009-03-19 10:44:26 EDT 
Marking as INVALID then.
Comment 4 Christine Rice CLA 2009-03-20 11:43:48 EDT 
Closing