Bug 269171 - [ftp][performance] Avoid excessive sending of NOOP commands
Summary: [ftp][performance] Avoid excessive sending of NOOP commands
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P2 enhancement with 1 vote (vote)
Target Milestone: 3.2 M6   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: performance
Depends on: 243921 267473
Blocks: 271015 295167 300394
  Show dependency tree
 
Reported: 2009-03-18 07:47 EDT by Martin Oberhuber CLA
Modified: 2010-03-15 19:52 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2009-03-18 07:47:29 EDT 
Looking at the FTP console log, I see excessively many NOOP commands.
This degrades performance a lot on connections with a high latency.

The sending of NOOP has initially been introduced with bug 243921, because it was the only way we knew at that time to check whether the remote side was still alive (connected). Bug 246651 is also related.

Today, and especially with the upcomming Commons Net 2.0, we may be able to do this in a better way. For the Telnet Terminal adapter, we have introduced EOFDetectingInputStreamWrapper in order to get notified when a socket connection is closed by the remote. It might be possible to re-use this for FTP as a better approach to knowing when the connection is dropped.
Comment 1 Martin Oberhuber CLA 2009-03-18 07:47:50 EDT 
Should look at this for our performance milestone, M7.
Comment 2 Martin Oberhuber CLA 2009-07-20 09:45:23 EDT 
Bug 271015 may also be related to this one.
Comment 3 Martin Oberhuber CLA 2010-02-26 19:09:24 EST 
Bulk update of target milestones to 3.2
Comment 4 Martin Oberhuber CLA 2010-03-15 19:25:40 EDT 
Fixed with the patch attached to bug 300394.