Bug 267473 - [ftp][telnet][releng][api] Upgrade to Commons Net 2.0
Summary: [ftp][telnet][releng][api] Upgrade to Commons Net 2.0
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api, Documentation
Depends on:
Blocks: 271015 220939 267474 269171
  Show dependency tree
 
Reported: 2009-03-06 20:14 EST by Martin Oberhuber CLA
Modified: 2009-04-20 10:18 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2009-03-06 20:14:58 EST
Apache Commons Net 2.0 includes many bug fixes compared to v1.4.1 which we are currently using. We should upgrade to the new version.

The new version brings a dependency to Java 1.5 with it, so it must be documented in the readme / build notes / release notes. Also, we re-export Commons Net in some of our interfaces, so it does touch on API (although the classes that we re-export have not been changed).

On the positive side, Commons Net 2.0 supports
   WindowSizeOptionHandler to support terminal size negotiation for telnet
   FTPS support

Commons Net 2.0 is already in Orbit. A CQ for legal clearance has been filed:
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=3188
Comment 1 Martin Oberhuber CLA 2009-03-06 20:19:19 EST
In FTPService, it was necessary to replace registerSpyStream(), but now our code should be compatible to run on either Commons Net 1.4.1 or 2.0.

Before adding the bundle to our build, we will need legal clearance, so I am marking this for M7.
Comment 2 Martin Oberhuber CLA 2009-03-18 07:28:51 EDT
Commons Net 2.0 has been released, and is available from Orbit today:
http://download.eclipse.org/tools/orbit/downloads/drops/S20090307012903/

IP Legal review for re-using is is still pending for TM:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=3188

But the code has been updated already to work with Commons Net 2.0. So, TM 3.1m6 will still be shipped with Commons Net 1.4.1 but you will be able to download the 2.0 version from Orbit and TM will automatically pick it up and use it. I'm confident that we can integrate Commons Net 2.0 with M7.
Comment 3 Martin Oberhuber CLA 2009-04-20 10:18:43 EDT
IP is cleared, added Commons Net 2.0 to RSE 3.1. This adds a dependency to Java1.5 for FTP and Telnet, and removes Apache ORO from RSE.

Released and tested with I20090420-0900.