Bug 268950 - [Commands] New APIs in IWorkbenchCommandConstants are missing '_' separators
Summary: [Commands] New APIs in IWorkbenchCommandConstants are missing '_' separators
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Dani Megert CLA
QA Contact: Paul Webster CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-17 07:33 EDT by Dani Megert CLA
Modified: 2009-04-29 03:02 EDT (History)
5 users (show)

See Also:
Mike_Wilson: pmc_approved+

Attachments
Updated API constants v01 (84.33 KB, patch)
2009-03-30 08:09 EDT, Paul Webster CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-03-17 07:33:17 EDT 
3.5 M6.

The new constants in IWorkbenchCommandConstants are missing '_' separators which make them hard to read and which make them differ from the action constant.

Examples:
- action is called CLOSE_ALL but constant is FILE_CLOSEALL instead of FILE_CLOSE_ALL
- action is called CLOSE_PERSPECTIVE but constant is WINDOW_CLOSEPERSPECTIVE instead of WINDOW_CLOSE_PERSPECTIVE


I'm sorry I did not notice before the API freeze. I suggest to ask the PMC to change that for final 3.5.
Comment 1 Paul Webster CLA 2009-03-30 08:09:37 EDT 
Created attachment 130231 [details]
Updated API constants v01

Update the API constants.  Improve readability and match the action constants.

PW
Comment 2 Mike Wilson CLA 2009-03-30 18:40:27 EDT 
I'm not strongly in favor of this, but if we're certain that no one (who hasn't agreed to update their code) has picked up the old constants I'm ok with fixing it.
Comment 3 Dani Megert CLA 2009-03-31 02:44:22 EDT 
Paul, I suggest we coordinate the change after today's I-build.
Comment 4 Dani Megert CLA 2009-04-01 12:41:23 EDT 
Fixed in HEAD (sent patches to Debug, PDE, Team and Compare which got applied).
Available in builds > N20090331-2000.
Comment 5 Dani Megert CLA 2009-04-29 03:02:05 EDT 
Verified in I20090428-0100.