Community
Participate
Working Groups
Created attachment 128960 [details] Example screenshot See the attached screen shot comparing the project explorer and package explorer in Eclipse 3.5 M6. The working sets, such as gmf-sdk-experimental.map, is missing the java errors/warnings resource decorations in the project explorer. These decorations are in the package explorer.
Anthony, do you have any steps to repro this? I have not seen this, so there must be some odd combination of things that have to happen to make this appear.
All I did was take Eclipse platform SDK, connect to a project in CVS and introduce an error in the source code. As you can see in the screen shot, the CVS decorations are there, the error decoration is missing. If you are really stuck in duplicating , let me know.
(In reply to comment #2) > All I did was take Eclipse platform SDK, connect to a project in CVS and > introduce an error in the source code. > > As you can see in the screen shot, the CVS decorations are there, the error > decoration is missing. > > If you are really stuck in duplicating , let me know. > Yes, I'm stuck. I did the same thing and the decorations properly showed up in both places. You can consistently make this happen? I also use the project explorer (instead of the package explorer) for my normal work and have not seen this, so I think this is some kind of intermittent problem or it's dependent on something else.
I just duped this on Windows (I was unable to dup it on Linux). I will try and track it down.
Going to have to push to RC1, needs to be fixed in 3.5 though, it was a pretty obvious problem on Windows.
Hello, can you tell if you would be able to meet the RC1 goal? Regards, Blazej
Time is running out for 3.5. Can this be moved to 3.5.1?
(In reply to comment #7) > Time is running out for 3.5. Can this be moved to 3.5.1? > We have this week for RC1, right? I will try to look at it tonight. This seems like a serious problem, I easily re-prod' it on Windows, it also seems like a regression. It would be fixed. I'm sorry I have had so little time lately.
(In reply to comment #8) > We have this week for RC1, right? As per the http://www.eclipse.org/eclipse/development/freeze_plan_3.5.php the RC1 build is on Thursday this week. However, RC1 testing will start on Thursday for some teams because of holidays (in Europe?), thus changes should be verified on Wednesday at the latest and thus have to be in the Tuesday 8pm build. So realistically, today is the last day of development for RC1 when taking into account that fixes need to be reviewed by another committer. I probably should have sent another reminder with these details on the mailing list, sorry.
I am ok with this moving to 3.5.1.
(In reply to comment #10) > I am ok with this moving to 3.5.1. > I can't make this happen anymore in I20090509, can you?
(In reply to comment #11) > (In reply to comment #10) > > I am ok with this moving to 3.5.1. > > > > I can't make this happen anymore in I20090509, can you? > I can with: Version: 3.5.0 Build id: I20090508-2000 Should I find I20090509?
(In reply to comment #12) > (In reply to comment #11) > > (In reply to comment #10) > > > I am ok with this moving to 3.5.1. > > > > > > > I can't make this happen anymore in I20090509, can you? > > > > I can with: > Version: 3.5.0 > Build id: I20090508-2000 > > Should I find I20090509? > Well let me try it with 0508. What did you do exactly? I checked out a project from CVS (org.eclipse.ui.navigator) and caused a compile error and it got decorated OK. I did several changes adding and removing complile errors and it all worked fine, regardless of whether the package explorer or project explorer was visible. Before when I tried it (a month ago or so, I easily reproduced it on my Windows Vista machine. You did this on Windows?
> > > > Should I find I20090509? I beg your pardon, the build I'm using is 0508-2000 (I did not test it on 0509), so it's the same.
I tried on Windows XP at work and Windows Vista at home. Problem still there.
Created attachment 135246 [details] Example on Vista
The issue is that I change the background colour to yellow for CVS outgoing changes. Window + Preferences => General + Appearance + Colors and Fonts Change CVS + Outgoing Change (background) to Yellow This causes the error decorations on the working set to disappear. Setting the default back brings back the decoration.
Yes, I see it now, in my testing before I was not looking at the working set, I was looking at the projects (when I looked at this a month ago, the project and packages also were not showing the errors which of course is much more severe). I can make it happen with or without the color changes. Oddly, changing the background color does not seem to actually change the color for me in either the package or project explorer, but that's another issue. We can deal with this after 3.5.
Problem also occurs with missing overlay icons and label text for Subclipse Subversion plugin with working sets displaying in the Project Explorer, but Package Explorer seems to display fine. (Also a problem in the Enterprise Explorer in Rational Application Developer 7.5.3.)
Created attachment 156473 [details] Part of suggested patch The problem here is that JDT does not provide the labels for the working set. As it does with resources, it should override the content provider in org.eclipse.ui.navigator.resources to provide the correct label information for the working set. This patch is a part of the solution, however it does not handle when the decorator changes. This is because the LabelProviderChangeEvent does not include the working set, so the ProjectExplorer will not trigger.
Clients of the CNF should not have to deal with this. Instead the CNF should add support for problem decorators, including propagation up to the working sets.
*** This bug has been marked as a duplicate of bug 264404 ***
