Bug 268505 - [Navigator] Do not deprecate org.eclipse.ui.ide.resourceFilters
Summary: [Navigator] Do not deprecate org.eclipse.ui.ide.resourceFilters
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Francis Upton IV CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-13 06:20 EDT by Dani Megert CLA
Modified: 2009-04-17 04:13 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2009-03-13 06:20:01 EDT
I20090312-2000.

Since the Navigator is still in use i.e. users can bring it to front, plug-in providers that have hidden resources have to make sure it is correctly working/configured so that users can use it. Therefore it is not right to punish said filters with a deprecation warning as there's no way such plug-in providers can get rid of that warning.

Please remove the deprecation of org.eclipse.ui.ide.resourceFilters until the Navigator can no longer be reached by users.
Comment 1 Francis Upton IV CLA 2009-03-13 06:32:20 EDT
I don't understand this; how is this different than deprecating the entire Navigator which has been done?  Anyone who uses any part of the ResourceNavigator is going to get a deprecation warning in 3.5.  I don't follow what's different or special about these filters.
Comment 2 Dani Megert CLA 2009-03-13 06:36:15 EDT
The difference is that those who use the code have an alternative. However, those which have to make sure that the existing Navigator still works as before have no other choice than keep their filter. Or to put it in other words: if you give me the replacement for this:

   <extension
         point="org.eclipse.ui.ide.resourceFilters">
      <filter
            selected="false"
            pattern="*.class">
      </filter>
   </extension>


which then filters the *.class files in the Navigator, I'm OK too.
Comment 3 Dani Megert CLA 2009-03-23 11:11:14 EDT
Can this please be fixed or an alternative be presented? Thanks.
Comment 4 Dani Megert CLA 2009-03-24 03:41:18 EDT
Francis, I see your point of wanting to deprecate this but the problem is that it results in warnings in all plugin.xml files that still have to extend the navigator in order to function well. And since problems are propagated to the parent it results in projects and working sets getting annotated with a warning that would otherwise be problem free. This is a major distraction.

We should only deprecated this at the time when it is no longer possible for Eclipse SDK users to make the Navigator appear but could add a comment about the deprecation of the resource navigator.
Comment 5 Francis Upton IV CLA 2009-03-24 04:00:29 EDT
(In reply to comment #4)

> We should only deprecated this at the time when it is no longer possible for
> Eclipse SDK users to make the Navigator appear but could add a comment about
> the deprecation of the resource navigator.
> 
I would be happy removing the deprecation for the extension point and putting a comment in that it really is deprecated just like the RN, but that we don't deprecate it now to avoid the compile warnings on our own stuff.  If you don't object, that's what I will do.

Comment 6 Dani Megert CLA 2009-03-24 04:04:05 EDT
Sounds good.
Comment 7 Dani Megert CLA 2009-04-16 03:09:51 EDT
Can you please fix this for M7 or I can do it if you're short of time.
Comment 8 Francis Upton IV CLA 2009-04-16 04:06:31 EDT
(In reply to comment #7)
> Can you please fix this for M7 or I can do it if you're short of time.
> 

I will get it done for M7, thanks for the offer of help; I'm planning on doing an Eclipse week before M7 to get lots of stuff done.
Comment 9 Francis Upton IV CLA 2009-04-16 13:03:26 EDT
Released to HEAD 3.5M7 N20060416-2000
Comment 10 Dani Megert CLA 2009-04-17 04:13:02 EDT
Verified in N20090416-2000.
Thanks Francis!