Bug 268467 - [api] improve support for propagating sync status for connectors that support multi bug retrieval
Summary: [api] improve support for propagating sync status for connectors that support...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 enhancement (vote)
Target Milestone: 3.3   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks: 268465
  Show dependency tree
 
Reported: 2009-03-12 23:05 EDT by Robert Elves CLA
Modified: 2009-09-24 16:02 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Elves CLA 2009-03-12 23:05:40 EDT 
Currently when an error occurs during synchronization only a single status can be propagated.
Comment 1 Steffen Pingel CLA 2009-05-06 00:50:01 EDT 
Rob, do you have any suggestions how to design this API?
Comment 2 Robert Elves CLA 2009-05-06 01:06:18 EDT 
What if the collector passed into the getMultiTaskData was modified to take a status (in addition to task data) that in turn gets set on the associated task?
Comment 3 Steffen Pingel CLA 2009-05-06 01:41:45 EDT 
How would you imagine that to work in case retrieval of a task fails? Would the connector return an empty TaskData object with along with an error status?
Comment 4 Steffen Pingel CLA 2009-05-06 01:44:42 EDT 
I like the idea of using the TaskDataCollector. We could add something like this:

 public void failed(String taskId, IStatus status) {
 }
Comment 5 Robert Elves CLA 2009-05-06 12:09:57 EDT 
Yeah, after posting I was thinking that passing an empty taskdata didn't make much sense.  I like your failed(..) method approach better.
Comment 6 Steffen Pingel CLA 2009-05-07 18:00:08 EDT 
Good. The only thing that we could improve upon is the name but I can't think of anything better than failed() at the moment . Do you want to go ahead and make the changes along with fixes for bug 268465?
Comment 7 Steffen Pingel CLA 2009-05-21 16:58:19 EDT 
+1 Looks good!
Comment 8 Robert Elves CLA 2009-09-24 16:02:21 EDT 
Committed.