Bug 268355 - [Net] checkboxes cut off in Network Connections preference page
Summary: [Net] checkboxes cut off in Network Connections preference page
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows Vista
: P3 trivial (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-03-12 10:28 EDT by Grant Gayed CLA
Modified: 2009-06-02 07:14 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (54.39 KB, image/pjpeg)
2009-03-12 10:28 EDT, Grant Gayed CLA 		no flags Details
Screen_01 (68.60 KB, image/jpeg)
2009-03-13 06:14 EDT, Pawel Pogorzelski CLA 		no flags Details
Patch_v01 (2.67 KB, patch)
2009-03-13 08:40 EDT, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grant Gayed CLA 2009-03-12 10:28:47 EDT 
Created attachment 128558 [details]
screenshot

I20090312-0100
- observed on Vista, doesn't happen on win2000, didn't try XP

- go to the General > Network Connections preference page and note that the checkboxes in the two Tables are cut off (screenshot is attached)
- ProxyEntriesComposite is setting the first column's width to 18, which seems to not be enough on Vista
  -> is there a reason that a column is being created for the checkboxes?
Comment 1 Pawel Pogorzelski CLA 2009-03-13 06:14:09 EDT 
Created attachment 128676 [details]
Screen_01

(In reply to comment #0)
> <text deleted/>
> - ProxyEntriesComposite is setting the first column's width to 18, which seems
> to not be enough on Vista

Right, I'll try to find a generic way to calculate that width.

>   -> is there a reason that a column is being created for the checkboxes?
> 

In addition to manually defined proxies the table also shows entries that are defined in the OS. In such the checkboxes are used to inform user which entries are active. The attachment shows what I mean.
Comment 2 Pawel Pogorzelski CLA 2009-03-13 08:40:39 EDT 
Created attachment 128696 [details]
Patch_v01

I tried call pack() on the first column but it results in the column being too wide. So I decided to simply make it a bit wider on all platforms.
Comment 3 Szymon Brandys CLA 2009-03-17 05:21:47 EDT 
Patch_v01 released to HEAD.