Community
Participate
Working Groups
Build ID: 3.4.1 Steps To Reproduce: It would be great if we could assign primary import/export wizards to a perspective. When the user brings up the File menu from the main menu bar, the Import and Export options would turn into cascading items. The entries in the cascade would be the primary wizards for that perspective, and an "Other" item to go to the regular selection dialog. This same scheme would be seen when right clicking in a navigator type view. More information:
I like the idea. We are past the API freeze for 3.5 but we can look into this for 3.6.
Prakash is now responsible for watching bugs in the [Wizards] component area.
Created attachment 153502 [details] Patch v01 First cut
Created attachment 153503 [details] Screenshot Sample of how it looks
Adding Boris to cc. Need his comments :-)
I like it. The question is how this would play if no primary import/export wizards have been defined - do we fall back to the current behaviour? We should get some more comments from people like Susan and McQ.
Looks nice. (In reply to comment #6) > I like it. The question is how this would play if no primary import/export > wizards have been defined - do we fall back to the current behaviour? > > We should get some more comments from people like Susan and McQ. I would assume we fall back to the current behavior. My only complaint is the same one I have for new wizards, show view, etc. The scalability when everyone thinks their stuff is the most important. I'm not suggesting we shouldn't do this, but just that we are careful/minimal in which items we promote to the Java perspective. (I have 15 show view shortcuts and 13 new wizard shortcuts running the SDK + Mylyn).
Cc-ing Dani for his comments. (In reply to comment #6) > > The question is how this would play if no primary import/export > > wizards have been defined - do we fall back to the current behaviour? We can make it to fall back to the older one. Right now it doesn't fall back. It just shows the Other... button. If we leave it this way, its little ugly and probably force the adopters to add the perspective extension ;-)
I like it as well but we should not overload the term "primary" here. For New wizards "primaryWizard" is part of the newWizards extension point and means that this wizard will always show up in the (Others) dialog. This is for products to configure the dialog. I think adding this in addition to what the attached patch does might be a big help for bug 268310. >we are careful/minimal in which >items we promote to the Java perspective. Sure, but it's not completely in our hands given we allow clients to extend this via prespectiveExtensions extension point. If we think that's an issue we could simply leave that one out but I think it would be unfair. In case where there are no primary wizards we must show the current 'Export...'/'Import...' menu items as there are many upstream products with custom perspectives that won't have time to adopt this new feature. Minor issue: 'Other...' misses the Ctrl+N mnemonic.
(In reply to comment #9) > Minor issue: 'Other...' misses the Ctrl+N mnemonic. Ctrl+N is for the New command. Why should it be mapped for Export or Import? If you had any keybindings for these commands, it should show up in the Other... of the respective menu.
(In reply to comment #10) > (In reply to comment #9) > > Minor issue: 'Other...' misses the Ctrl+N mnemonic. > > Ctrl+N is for the New command. Why should it be mapped for Export or > Import? If you had any keybindings for these commands, it should show up in the > Other... of the respective menu. Sorry, I was too fast. I only wanted to remind, that we should not forget the mnemonic but of course I can't tell from the picture whether it's there or not. I wrongly pasted the shortcut instead of 'O', which is the mnemonic.
(In reply to comment #11) > Sorry, I was too fast. I only wanted to remind, that we should not forget the > mnemonic but of course I can't tell from the picture whether it's there or not. > I wrongly pasted the shortcut instead of 'O', which is the mnemonic. OK. I was confused of why should Ctrl+N be supported there :-) Although its not in the screenshot, if we have defined a keybinding for Export/Import in the preference page, it will show up there.
(In reply to comment #9) > >we are careful/minimal in which > >items we promote to the Java perspective. > Sure, but it's not completely in our hands given we allow clients to extend > this via prespectiveExtensions extension point. If we think that's an issue we > could simply leave that one out but I think it would be unfair. I wasn't proposing we leave it out, just that we don't go overboard in the places where we do have control (select carefully which SDK ones are primary), knowing that other plug-ins will certainly add to this list.
Created attachment 153702 [details] Patch v02 Support added to the CustomizePerspectiveDialog
Created attachment 153703 [details] CPD Screenshot
Prakash, we shouldn't create new (not New :-) wizard shortcut actions. We already have commands that can open a specific import/export/new wizard, and we should update the CompoundContributions to use them and CommandContributionItems instead of NewWizardShortcutAction and 2 new actions. PW
Created attachment 154555 [details] Patch v03 Now using wizard handlers. And the implementation falls back to the old menu item, when the extension point is not used.
Created attachment 154556 [details] Screenshot Screenshot. Also show how the shortcuts are mapped.
Later ...
