Community
Participate
Working Groups
Created attachment 128182 [details] Screenshot I20090310-0100 Customize Perspective dialog, click on the checkbox of a disabled item. A warning dialog appears with several problems: - Dialog title should be name of an action, not a message - String concatenation is not the right means to compose strings (see CustomizePerspectiveDialog.UnavailableContributionItemCheckListener.checkStateChanged(..)). Especially not if there's no space between sentences... - The dialog is not really helpful. Why would I want to expand the item if I still cannot do anything afterwards? You should better ask me if I would like to go to the command group to actually make it visible.
How about in this case we just show the same dialog that we show when you try to 'select' a leaf (i.e. one of the items you get if you and 'Yes' to the current dialog) ? Also, what would you suggest for a title ?
> How about in this case we just show the same dialog that we show when you try > to 'select' a leaf (i.e. one of the items you get if you and 'Yes' to the > current dialog) ? Sounds good (regardless of the expansion state, of course). > Also, what would you suggest for a title ? Something like "Make Item Visible", or just repeat "Customize Perspective" from the parent dialog.
Beauty, I've tagged this for M7...
Created attachment 132786 [details] Patch to tweak the dialog Markus, this patch changes the dialog's title and removes the Yes/No prompt, reverting to a simple explanation and an OK button. Since the prompt message is gone so is the concatenation issue...
Committed in >20090422. Applied the patch.
Verified in I20090428-0100.
