Bug 26765 - [painting] Add option for line spacing
Summary: [painting] Add option for line spacing
Status: CLOSED MOVED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.0.1   Edit
Hardware: All All
: P5 enhancement with 48 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 361632 533809 (view as bug list)
Depends on: 68264
Blocks:
  Show dependency tree
 
Reported: 2002-11-20 09:17 EST by Brett Kotch CLA
Modified: 2022-11-30 03:04 EST (History)
24 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Kotch CLA 2002-11-20 09:17:13 EST
The default spacing for a particular font may not be the desired spacing. 

Adding an option for line spacing would allow a user to set how far apart each 
line is.
Comment 1 Brett Kotch CLA 2003-10-15 20:02:59 EDT
Workaround ... create a new font with desired spacing and use that as that font.
Comment 2 Mike Wilson CLA 2008-04-13 15:18:36 EDT
Closing for lack of activity. Please re-open if we plan to implement this.
Comment 3 Dani Megert CLA 2008-04-14 05:42:55 EDT
SWT added API for this during 3.2 or 3.3. We could leverage this but I doubt many users would change that preference and having yet another preference isn't what I'd like to do. Agree to leave as WONTFIX unless we get more votes for this feature.
Comment 4 Dani Megert CLA 2011-11-22 03:01:12 EST
*** Bug 361632 has been marked as a duplicate of this bug. ***
Comment 5 Michael Woski CLA 2011-11-22 07:21:46 EST
(In reply to comment #4)
> *** Bug 361632 has been marked as a duplicate of this bug. ***

line spacing is as much a readability feature as syntax colouring and indentation is. Nobody questions the latter two ...

It doesn't necessarily mean a new appearance preference, you could also put it into the formatting rules.
Comment 6 Tobiáš Potoček CLA 2012-04-03 05:34:39 EDT
I think it's time to re-open this request. The screens are getting bigger, resolutions are getting smoother, so we don't need to spare every pixel anymore and bigger line height significantly increases code readability.

See the difference: http://img522.imageshack.us/img522/3315/eclipseyh.png

I know this is very subjective but I can't be the only one who would appreciate this. And it also can't be that hard to implement.
Comment 7 Dani Megert CLA 2012-04-03 06:19:31 EDT
We won't work on this but we'd accept a high quality patch.
Comment 8 Leon Zeng CLA 2012-11-21 23:16:34 EST
It's a great pity that such a popular IDE has been using such an ugly view for 10 years and refuse to fix it. Stupid, it destroyes the whole product.
Comment 9 Leon Zeng CLA 2012-11-21 23:19:27 EST
Does any other IDE use such a small spacing?
Comment 10 Francisco Corrales CLA 2014-04-23 13:57:14 EDT
This would be awesome !, please reconsider to make this !

Eclipse is the best-and-most-used IDE ! this 'little' things (features, settings) are what makes it the best !

This would avoid me to insert a new line in the code !, I really want this !
Comment 11 Dinçer avraal CLA 2014-04-23 17:07:11 EDT
(In reply to Leon Zeng from comment #9)
> Does any other IDE use such a small spacing?

Not an IDE in its all meaning however, Sublime Text is the best as providing cross platform editor. View is the best at least I could tell.

Building options and other preferences are not advanced, but it does the job. Reading the code is much more easier. Also it has Notepad++ style multi-language highlight support. It has a limited code completion however though has very small footprint.

By the way, it is python based.
Comment 12 Niko Wicaksono CLA 2014-08-08 22:19:34 EDT
NetBeans also offer line-height correction via direct edit to configuration files.
Comment 13 wenming fu CLA 2016-06-30 03:52:56 EDT
Please help make this happen, it is really important for user experience.
Comment 15 Rustam Abdullaev CLA 2016-07-11 04:58:27 EDT
There are other apps where line height is not configurable.
A possible workaround: use a font with an artificially increased line height, such as this:
https://github.com/andreberg/Meslo-Font

Although I do not understand why the *same font* (e.g. Consolas) looks way more cramped in Eclipse than in other apps?
Comment 16 Dani Megert CLA 2018-04-19 09:10:13 EDT
*** Bug 533809 has been marked as a duplicate of this bug. ***
Comment 17 Roman Knoell CLA 2018-07-31 06:11:04 EDT
Please FINALLY add an option for setting the line height / line spacing. Xcode has it, IntelliJ has it. I have been waiting for this for years now. Eclipse looks, compared to these IDEs, just terrible. Why is that necessary? Eclipse is still a great IDE, also for Scala. Many users are used to it and cherish its power and adaptability. I am thankful and glad we can use it for free and fully aware of the fact that many people put a lot of work and effort into Eclipse pro bono publico.
Just after researching for a line-space-setting solution for Eclipse for almost two days (even considering CSS, which I finally used to hide the tool bars years ago, which should be just a menu option, so trivial, to get a distraction free work environment), I considered and set up IntelliJ for the first time, for now working with both IDEs.

In addition this would possible solve / ameliorate this bug leaving users with a seriously awful feeling: https://bugs.eclipse.org/bugs/show_bug.cgi?id=206740.
Comment 18 Dani Megert CLA 2018-07-31 10:21:53 EDT
(In reply to Roman Knoell from comment #17)

Thanks for your comment, but unfortunately this bug seems not to be important enough for developers. Eclipse is an Open Source project and this bug has the 'helpwanted' flag for more than 6 years. So, if you or anyone else cares, please provide a high quality Gerrit change.
Comment 19 Mchael Pujos CLA 2020-09-17 12:13:07 EDT
Coming back from a few month of using Intellij IDEA, I was looking for a line spacing setting in Eclipse...
It is in particular very useful on laptops to increase text density (reducing line spacing) without decreasing font size.
Comment 20 Taro Kyo CLA 2020-11-17 14:22:45 EST
We have a lot of requests since 16 years ago for a line height customization setting for Eclipse.

I am curious to know which files should changes need to be applied to in order for someone interested to write a patch?
Comment 21 Paul Pazderski CLA 2020-11-17 14:33:52 EST
(In reply to Taro Kyo from comment #20)
> I am curious to know which files should changes need to be applied to in
> order for someone interested to write a patch?

The basis for all feature rich editor components is StyledText from SWT. [1]
AFAIK this component has already all the support in line height flexibility someone would need for this feature request.

I would start in org.eclipse.jface.text.TextViewer or SourceViewer from the Text project. [2]
In best case there is not much more to do than setting another line height on the backing StyledText.

[1] https://git.eclipse.org/c/platform/eclipse.platform.swt.git/
[2] https://git.eclipse.org/c/platform/eclipse.platform.text.git/
Comment 22 Paul Pazderski CLA 2020-11-17 14:55:37 EST
Having flexible configuration for line height and not just hacking around might be the harder part. You may find inspiration in how fonts are handled around AbstractTextEditor [1] getSymbolicFontName() and as more complex variant how Jave Editor use its own font "org.eclipse.jdt.ui.editors.textfont" in [2].

[1] https://git.eclipse.org/c/platform/eclipse.platform.text.git/tree/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/AbstractTextEditor.java
[2] https://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/tree/org.eclipse.jdt.ui/plugin.xml