Bug 267556 - [GlobalActions] RetargetActions created by ActionFactory should unregister from PartService
Summary: [GlobalActions] RetargetActions created by ActionFactory should unregister fr...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.2   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-08 15:53 EDT by Carsten Pfeiffer CLA
Modified: 2019-09-06 16:05 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Pfeiffer CLA 2009-03-08 15:53:47 EDT
ActionFactory creates some RetargetActions (e.g. ActionFactory.PRINT.create()), and also registers them as IPartListener with the passed IWorkbenchWindow's IPartService.

This is not documented, and if the client doesn't know about this, his actions will linger on forever, reacting to part events.

I'd expect them to unregister from the part service when they are disposed.

RetargetAction.dispose() *does* unregister from a part service, but that is not (necessarily?) the same as the workbench window's.  

So IMHO, the create() methods should return a subclass of RetargetAction that reimplements dispose() to also unregister from the workbench window's part service.
Comment 1 Eclipse Webmaster CLA 2019-09-06 16:05:55 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.