Bug 267171 - Compare editor on local file: 'Open' action should set selection
Summary: Compare editor on local file: 'Open' action should set selection
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2009-03-05 05:41 EST by Markus Keller CLA
Modified: 2010-04-26 07:56 EDT (History)
3 users (show)

See Also:

Attachments
Fix (13.21 KB, patch)
2010-03-25 04:41 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2009-03-05 05:41:15 EST 
I20090304-0834

Have a compare editor on a local file. The context menu contains an 'Open' action, which opens the file in its full-fledged editor. Most of the time I use this action, I want to see the same region I already looked at in the compare editor.

The 'Open' action should set the selection in the new editor based on the selection in the compare editor. Even better would be to also set the same visible viewport (at least the same first line), since you often scroll in the compare editor without having moved the caret.
Comment 1 Tomasz Zarna CLA 2009-03-05 07:04:20 EST 
Agree, this would be a nice feature to have.
Comment 2 Dani Megert CLA 2010-03-24 13:08:40 EDT 
Agree. Nice polish item.
Comment 3 Dani Megert CLA 2010-03-24 13:24:20 EDT 
Let me fix this.
Comment 4 Dani Megert CLA 2010-03-25 04:41:22 EDT 
Created attachment 162963 [details]
Fix

The fix extends OpenFileAction and OpenWithMenu, which is currently not allowed. I filed bug 307026 to open this up during 3.7. For now we just ignore those two warnings since this is much better than copying the whole code of those two classes and it super classes.
Comment 5 Dani Megert CLA 2010-04-20 10:56:09 EDT 
Fixed in HEAD.
Available in builds >= N20100420-2000.
Comment 6 Markus Keller CLA 2010-04-26 07:56:14 EDT 
Very nice! Verified in I20100425-2000.