Community
Participate
Working Groups
branch_20090126_LocalDiff Is there any particular reason why we validate patch root provided manually in the create local diff wizard? Currently, only existing paths are accepted. This doesn't allow us to ignore leading path segments which was, correct me if I'm wrong, the main reason behind this option.
Since it's a blocker of bug 71374, my questions is when the fix will be ready.
So, just to clear things out, we don't need patch root's validation, because we want to be able to enter a path, which may be outside of the current workspace. And the correct behaviour of patch root is described in bug 267003, right ?
(In reply to comment #2) > So, just to clear things out, > > we don't need patch root's validation, because we want to be able to enter a > path, which may be outside of the current workspace. > > And the correct behaviour of patch root is described in bug 267003, right ? > In bug 267003, I described a case when we can't continue using the suggested value. That's weird. I think that we should allow to continue even using a path to a location outside the workspace or paths like "Local history:...". In such cases I would expect a warning/info in the wizard header though.
Created attachment 129605 [details] Patch_v1 Patch resolving issue. > In such cases I would > expect a warning/info in the wizard header though. Warning added if patch root is outside the workspace or is not a valid path.
Created attachment 130227 [details] Fix v02
Created attachment 130229 [details] Fix v02 with changes I found more issues with your Patch_v1. I fixed some of them in my latest fix. I think that you should look carefully at the code and remove at least all the warnings. There is another bug for refactoring raised by Tomasz. I hope that the fix for it will cover warnings too.
Released to the branch_20090126_LocalDiff.
