Community
Participate
Working Groups
I was very much looking forward to the new custom key binding support in M3 so I could bind a key to the 'current window' maximize/restore functionality. However there appears to be no defualt key binding for such a maximize/restore function, and no way to bind any key to that action. I currently find it very annoying that I have to double click on the title bar of the editor window (or right click on the title bar and pick from the menu), instead of having a key binding that I can use for this, as available in most other IDEs.
I'd find this very useful too (see bug 1978). The current shortcut is awkward because it requires three key presses, and maximize (Alt-,x) currently requires a different combination from restore(Alt-,r)). Ideally this would be a single toggle action that could be bound to a single shortcut.
I'm also quite excited about the possibility of binding this action to a mouse gesture. Gesture up for maximize, gesture down for restore would be very intuitive. This is part of my ongoing quest to eliminate double-click from my UI manipulation vocabulary
Is there any chance at all this can make it into 2.1? This seems like a fairly small change (in terms of code), but would make using Eclipse day significantly more efficient for a number of people. Being able to switch back and forth quickly between a large editor view and a normal view is especially important for people with weak eyesight (like myself) since they generally need to use larger fonts, so can't display as much onscreen.
this is the responsibility of the workbench to add these actions. once that is done, you will automatically be able to customize the key bindings.
There are no plans for the UI team to work on this defect until higher priority items are addressed. If you would like to work on this defect, please let us know on the platform-ui-dev mailing list.
As a way of testing, I added this functionality to the UI. I will attach the patch files (patch computed against RC1). I don't care if this gets into 2.1, but I thought I'd attach the patch so it doesn't get lost. Summary of changes: org.eclipse.ui: - added command and acceleratorSet to plugin.xml - added translation of command name and desc to plugin.properties org.eclipse.ui.workbench: - new action, MaximizePartAction - hooked action to "Keyboard Shortcuts" menu in WorkbenchActionBuilder - added translations to messages.properties
Created attachment 3726 [details] patch file for org.eclipse.ui project
Created attachment 3727 [details] patch file for project org.eclipse.ui.workbench
I would like to strongly support the addition of mouse gestures to the Eclipse editor. In addition to maximise and minimize, I would want to see Close, Back and Forward added. The Opera web browser should be seen as the model to follow here. (Close would be the most useful, as its still a pain in Eclipse...)
Thanks to John Arthorne, there appears to be a patch attached to this feature request which implements this functionality in a reasonable fashion. Now that 2.1 is out, is there any chance this patch can be applied relatively soon before the codebase starts drifting too far? The previous comment prior to his attaching the patch was that there were higher priority items for the UI team to work on but if somebody else wanted to work on it that would be welcome, so hopefully there is nothing standing in the way of getting this in now.
Hi, I had submitted feature request id=37250 for the same. https://bugs.eclipse.org/bugs/show_bug.cgi?id=37250 As I was not aware of this bug report. I want exactly the same thing -- A key binding to maximize/restore the current window. I saw the patches attached to this bug. PLEASE how can one use these patches ? I use Eclipse Platform Version: 2.1.0 Build id: 200303071024 rgds g1
Jeevan, you can always add your vote to the bug to help increase its visibility.
*** Bug 24251 has been marked as a duplicate of this bug. ***
*** Bug 37250 has been marked as a duplicate of this bug. ***
Patch was applied today and will be part of the next integration build. Some changes were required because of code changes since 2.1 M1 build. Also, some changes to MaximizePartAction was done since it was not quite right. The shortcut key is Ctrl+M, however, I see that JDT is using this one too for Smart Typing...not sure what shortcut JDT uses for "Dumb Typing" ;-) Anyway, this will need to be resolved. It would be nice if the menu item changed from Maximize to Restore depending if the active part is maximized or not. Unfortunately, there is no notification when this state changes currently in the perspective.
Ctrl+M is no longer used for smart typing by JDT UI, since mode toggling is done using the Insert key now. -> all good.
I think Ctrl+M is too strong an accelerator to use for Maximize. Other editors, e.g. the HTML editor in WSAD may use this. Some other possibilities: - F12 - Ctrl+Shift+M - leave it unbound, and let the user specify the key binding (safest, but not great for out-of-box experience) Erich, any preference from the JDT team?
Meant Ctrl+F12 instead of F12.
I just chose Ctrl+M to be consistent with VA/Java (and because it's intuitive). Since the bindings can be customized, I have no strong preference. Ctrl+Shift+M seems better than Ctrl+F12 since it's more easily reachable by a touch-typist without straying far from the home row.
I checked with the wsadie team (based on 2.1.1), and looking at the shortcut customize preference page, no one is using ctrl+m Of course, there could be an editor that is using ctrl+m but not using the key binding service yet. I'm ok with not using ctrl+m is some other editor needs it...but I definitely would want some shortcut key assign to it out-of-the-box.
I think anybody that actually needs this command is going to use it a lot, probably more often than the majority of keystroke shortcuts. If you need it, you need it because you want more screen real-estate, but on the other hand, you also have to switch back to normal mode to do some activities. I know when I was using the similar feature in JBuilder (curtain?), I would use it all the time. I know that if you put it on some hard to reach keys, I would map it to something like Ctrl-M anyways. So I think it (the question about what key to put it on) depends on how many people you actually think would use and benefit from the feature :-)
when i first created this request (or another one that was merged into this one), i suggested F12 (if i recall) as the default gesture, because its fast and i have a vague memory it was F12 in some other IDE i used to use years ago. gesture ease/speed are key to make this a productivity enhancement. Ctrl-M is a fine, fast alternative. - craig
I still prefer Ctrl-M or Craig's suggestion of F12, but if something that is three keys is desired, how about Ctrl-Alt-Z? I seem to remember JBuilder uses this for the same action, and it is actually easy to type with one hand without looking, since the keys are very close together.
+1 for a short shortcut (short <= 2 keys).
Tom, you mentioned smart typing is no longer using Ctrl+M, but it is still in use in the latest integration build (I20030618). Do you know if this will be removed soon? As it is, it conflicts with the new maximize/restore action which is currently using Ctrl+M.
Oops, that's a leftover... will be removed tonight.
Removed and released to HEAD.
shouldn't this bug be resolved fixed? I suggest people vote for other bugs!
Ctrl+M is fine for now. This PR can be closed.
Closing as per Nick's comments
is Ctrl-Enter now also removed as a shortcut for this behaviour? Very annoying that it does this.. (and it is not listed as the keybinding for that in the keys preference section)
No, that is a different problem. See bug 42225.
