Community
Participate
Working Groups
In the attachment dialog for the image, support the following method - Getting from clipboard - Getting from image file And, The annotation tools are increased. - Line - Rectangle - Oval
Created attachment 126712 [details] screenshot.png This is the implemented wizard page
That looks awesome! Are you interested in contributing a patch?
Created attachment 126835 [details] capturedialog.patch
Created attachment 126836 [details] newicons.zip New icons
Thanks! One of the features that could be very useful is a way to add text to a screenshot. Do you think it would be very difficult to add that as well?
Hiroyuki: Wow, this looks fantastic! If you're interested in additional improvements, a very common use case for the screenshot capture tool is to annotate a screenshot with some additional information. I don't know how hard this would be, but being able to create a shaded text box would be a great addition.
It seems to take time to mount the text drawing. When enhancing (undo, redo, the line kind and the thickness) , examined.
Created attachment 127074 [details] NewTool.png My goal is the following. Capture image of Desktop [New] Loading image from Clipboard and image file (Note: depends SWT implementation) [Extend] Show image: Fit mode and Zoom mode: 100%, 200%, 400%, 800% [Extend] Draw tool: Free, Line, Rectangle, Round Rectangle, Oval and Text [Extend] Full color of the drawing line [New] Selection of the font face, size, style and color [Extend] Line style: Sold, Dot, Dash, Dash Dot, Dash Dot Dot [New] Line tickness: 1, 2, 4, 8 dots Clear all annotations [New] Undo and redo of one annotation (No limitation)
Created attachment 127102 [details] screenshot.patch The text drawing tool was implemented To evade the SWT bug, the Tab draws as one space.
Created attachment 127103 [details] screenshot_newicons.zip
The method of drawing text is done according to the following procedures. 1. Capture desktop or load image 2. Set zoom as 100%, 200%, 400% or 800% 3. Click Annotate button 4. Select Text draw tool 5. Click Font button, and select font name, size, style and color 6. Click and drag for drawing rectangle 7. Typing string if caret is displayed 8. Click point of outside rectangle
Created attachment 127110 [details] screenshot.patch Sorry, the detected bug was fixed
Steffen will continue to mentor your patches, but I just wanted to say that it's excellent to see this progress Hiroyuki! A lot of people are going to appreciate this functionality. I encourage you to break up your contributions into individual patches that are 250 lines of code or less, whenever that makes sense. That makes it much quicker for us to apply them, because they don't require IP review. For example, you could break up the different features you'e adding into separate patches.
I understood that your request is divide the patch. The patch is made 8 blocks. Show image: Zoom mode: 100%, 200%, 400%, 800% and, common Action class definition 9 line -, 249 line+ (39 blank lines + 210 modified line) Loading image from Clipboard and image file 11 lines -, 166 lines + (31 blank lines, 135 modified lines) Full color of the drawing line 18 lines -, 25 lines + (25 modified lines) Draw tool: Line, Rectangle, Round Rectangle, Oval 4 lines -, 175 lines + (37 blank lines, 138 modified lines) Line style: Sold, Dot, Dash, Dash Dot, Dash Dot Dot, and, Line tickness: 1, 2, 4, 8 dots 101 lines + (31 blank lines, 70 modified lines) Draw tool: Text, and selection of the font face, size, style and color 197 lines + (23 blank lines, 174 modified lines) Undo of one annotation (No limitation) 1 lines -, 240 lines + (24 blank lines, 216 modified lines) Redo of one annotation 38 lines + (5 blank lines, 33 modified lines) Please note that the following patch can be made only when one patch is applied. Can you wait for the period of the IP review? I will cooperate in the patch division when you immediately need this function.
*** Bug 250884 has been marked as a duplicate of this bug. ***
Hiroyuki, I have tried the patch and this is really cool! What do you think about adding a zoom mode to fit the cropped region? This would work perfectly for the use case where you capture the entire desktop but only want to attach and annotate a small part of the entire screen. Can you please add an EPL copyright header and @author tags to all new files you created in the patch? I'll then put this up for IP review so we can hopefully add this in time for Galileo.
Created attachment 127892 [details] newtoolbar.png I want to change the toolbar. It will become easy to use more. The following will be added to a new patch. Zoom 50% Capture the selected rectangle
Created attachment 127914 [details] screenshot_newicons.zip
Created attachment 127915 [details] screenshot.patch New patch
That's an interesting approach. Having more controls available as icons is easier in terms of usability but I'm a bit worried that the UI is getting to complex. My sense is that the most common use case is to capture, crop and annotate using a pen or text. It's great to have more advanced tools available as well but I am not sure if these should be exposed as icons on toolbars. I really like the version from March 1st. Having the toolbar on top allows descriptive names in addition to icons and works nicely with the drop-downs. Based on the patch from March 1st, how about this: - Keep "Capture", "Zoom", "Crop" and "Annotate" - Make the default action of "Zoom" to Fit (if the user has cropped, Zoom to 100% and center the cropped area) - Put "Free", "Rectangle" and "Text" as buttons in the toolbar. - Add one button that is a drop-down which has advanced tools and options: * Oval * Round Rectangle * ... -- * Line Style * Solid line * Dotted line * .. * Font Style... - Add a toolbar button for choosing the color with a drop-down that has a selection of colors (like the current implementation but in a menu) and an option to choose a custom color. - Keep the "Clear", "Undo" and "Redo" buttons (this is a really awesome addition!)
Wow Hiroyuki, this is shaping up to be one of our best community contributions to date. The only thing I noticed you using in your own screenshots, which is not yet captured by the tool, is arrows. It seems that these will be a pretty common thing with screenshots, so if it's not too hard you could consider making an arrow tool.
Created attachment 128171 [details] screenshot.png It implemented. It are one side arrow and both sides arrow.
About comment #20 I think that can easily operate the vertical tool palette, and use it easily. It is annoying to select each drop down menu. Please discuss it with the your meeting. If the conclusion is the horizontal tool bar, I add an additional function to the previous patch.
Thanks. That's wicked. I have added an item to the meeting agenda. Please feel free to join the call: http://wiki.eclipse.org/Mylyn/Meetings.
Created attachment 134062 [details] capture.patch The improvement was completed.
Created attachment 134063 [details] capture_newicons.zip New icons
Created attachment 134067 [details] capture.patch New patch
Created attachment 134078 [details] capture.patch Sorry, I found bug, and fixed it. Patch is uploaded again.
Created attachment 134195 [details] screenshot
(In reply to comment #29) > Created an attachment (id=134195) > screenshot That string is used in org.eclipse.mylyn.tasks.ui /src/org/eclipse/mylyn/internal/tasks/ui/editors/TaskEditorAttachmentPart.java . And, it is defined in /src/org/eclipse/mylyn/internal/tasks/ui/editors/messages.properties . Is the meaning that you request a updataion of that string? (But, the wizard title is not updated)
Please, add this features!
This is looking great Hiroyuki! I just attached the screenshot as an example to discuss it at the next Mylyn meeting. In order to avoid overloading the UI the suggestion I would make is to group the options for selecting the line width and line type (dotted line etc.) in a drop down. I would also limit the default color choice to something like four colors and allow the user to pick additional colors from the picker or a drop down.
Hiroyuki: Once again, great to see this progress. We discussed this contribution during the weekly call and want to proceed on incorporating it. The main concern we have is that the UI is overly complex, but it seems quite straightforward to simplify. We did a review and agreed that it was best to ensure that it was very easy to do the most common screenshot-specific actions, and that we could simplify by removing or hiding some of the more drawing-specific actions. In order to do this, we need to identify the key use cases for screenshots. Here's a start: 1) Point to a something in the screenshot with an arrow tool 2) Annotate screenshot with text 3) Block out a region of the screenshot 4) Bring attention to a region with a box 5) Draw freeform lines To support this, I think that we could merge some of your drawing tools into specific tools that support the four actions above. For example: 1) Single arrow tool with a fixed weight (2pt) 2) Current text tool 3) Filled box, rounded corners to look nicer 4) Empty box, rounded corners 5) Current freeform line tool (2pt) To make the UI for this simple, I suggest having these 5 tools along the left-hand-side of the image, especially since the vertical height is quite constrained by the wizard layout. For a color selection we can have a drop down with the current color layout. This should mean 5 regular buttons and one drop-down button, so the result should be simple enough. If you prefer to keep some of the more advanced functionality, you could make another button that allows the user finer grained control of things like drawing shape and line weight. Steffen can iterate with you on this. Also, we do understand if you do not have time to do this next iteration, and can take the contribution as-is and do some of these changes on our own after it is accepted. Just let us know what you prefer. Thanks again, we're looking forward to getting this into the hands of users for Mylyn 3.2.
Hiroyuki, it's fine to leave all the functionality and icons in the contribution for others to reuse as long as we can come up with a simplified UI for the screenshot capturing (comment 33). Let me know if you are interested in working on this in the next few days, since we are already past the IP deadline for Galileo and should submit this contribution for review asap.
Thank you for the response. The proposal of the simplification of UI is mounted. Improvement UI will be able to be sent to 5/7 or 8 JST.
Great! Thanks.
Created attachment 134984 [details] ui-sample.png I thought about UI (attached image). How do you think?
That looks very good. How is the currently selected tool indicated? I liked the previous solution where the tool buttons would toggle but that won't work in combination with the drop-downs as far as I know. You could consider changing the icon of the Annotate button to always reflect the current tool. Not sure the Dock On option is needed. Just having the toolbar visible on the left should be fine but we can leave it in if you think it's important. I think we are pretty close and it could make sense to put a patch up for IP review. Once we are through with the process and have the code in cvs we can still work out some of the nits later.
(In reply to comment #38) > How is the currently selected tool indicated? The image and tooltips of the tool button if the tool is selected on the drop down list. Note: Special specification for the tool button for Arrow/List/Box/Text - shows in the selection color rectangle. - And, a little shadow is added in my plan. > Not sure the Dock On option is needed. OK, it is erased.
Sounds good. Once you post the patch I'll try it and then submit the CQ.
Created attachment 135048 [details] capture.patch Improved I tested Vista & SUSE (GTK)
Created attachment 135049 [details] capture_newicons.zip Icon files for Patch
Sorry, modify after apply patch 1) to comment line 317, 318 (following lines) undoAction.setEnabled(false); redoAction.setEnabled(false); 2) to comment line 347, 348 (following lines) undoAction.setEnabled(false); redoAction.setEnabled(false);
Thanks Hiroyuki! I have submitted CQ 3291.
About patch, It is wrote 100% of the code which is thought myself. This code is contributed to Eclipse Mylyn project.
*** Bug 276428 has been marked as a duplicate of this bug. ***
The CQ has been approved. I have committed the patch to CVS with minor modifications: I moved most of the images to an internal class ScreenshotImages and commented out the lines mentioned in comment 43. Thanks a lot for your hard work Hiroyuki! This will certainly be one of the noteworthy features in the Mylyn 3.2 release.
Nice work on this one. I really love the new drawing features.
I echo those sentiments and will make sure that Hiroyuki is appropriately credited in the announcements around Mylyn 3.2.
