Bug 263976 - [content type] XMLRootElementContentDescriber2 need support for schema version
Summary: [content type] XMLRootElementContentDescriber2 need support for schema version
Status: REOPENED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Resources-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2009-02-06 12:11 EST by Karen Butzke CLA
Modified: 2019-09-06 16:09 EDT (History)
2 users (show)

See Also:


Attachments
proposed patch against HEAD to support contentType version (4.60 KB, patch)
2009-02-06 12:11 EST, Karen Butzke CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2009-02-06 12:11:25 EST
Created attachment 124978 [details]
proposed patch against HEAD to support contentType version

The WTP Dali team needs a content type that is only different by the schema version. We are currently using XmlRootElementContentDescriber2 as our content type describer and are specifying the namespace and root element name.  Now we need support for a version as well.

I have attached a patch with a possible fix for this issue.  The content-type element value is now described with {namespace}name/dtd:version
Comment 1 Szymon Brandys CLA 2009-02-09 04:31:00 EST
Please note that super class of XMLRootElementContentDescriber2 e.i. XMLContentDescriber is API now. You could extend it and create a describer that considers the version.

However if you think that XMLRootElementContentDescriber2 should support the version, your patches are welcome. It would be desirable, to have javadoc and tests updated too.

Comment 2 Szymon Brandys CLA 2009-06-05 07:41:03 EDT
Marking WONTFIX, see comment 1.
Comment 3 Paul Fullbright CLA 2009-08-03 10:26:45 EDT
Hey, was this closed because we didn't yet provide javadocs and tests?

We recently had this bug opened against us: bug 285370

One solution to that would be to add the content type describers that we use, such as the one that tests for version as well, to foundation plugins.  Is this still an open possibility?
Comment 4 Szymon Brandys CLA 2009-08-03 10:41:39 EDT
(In reply to comment #3)
> Hey, was this closed because we didn't yet provide javadocs and tests?
Really it was because XMLContentDescriber is API now (as described in comment 1), so now you can create an arbitrary xml describer by extending this API.

> One solution to that would be to add the content type describers that we use,
> such as the one that tests for version as well, to foundation plugins.  Is this
> still an open possibility?
Sure. However tests and robust javadocs are required.
Comment 5 Paul Fullbright CLA 2009-08-03 10:47:45 EDT
(In reply to comment #4)
> (In reply to comment #3)
> > Hey, was this closed because we didn't yet provide javadocs and tests?
> Really it was because XMLContentDescriber is API now (as described in comment
> 1), so now you can create an arbitrary xml describer by extending this API.

Right, and we did do that.  But the extension point is loading the describer and our plugin.  We *could* work around that, but to me it makes more sense to try and contribute the content describer version support back to core.
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:09:04 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.