Community
Participate
Working Groups
It might be useful to add a method IListProperty.lists(IListProperty) to string together a list of lists into one giant list. e.g. IListProperty children = BeanProperties.list("children"); IObservableList grandChildren = children.lists(children).observe(person);
MultiList(IObservableList<IObservableList>) would be a good start..
Created attachment 124740 [details] Unfinished draft Need to implement a value property to IObservableList<element> master to IObservableList<IObservableList for element> detail in such a way that when the first list removes/replaces an element that the IObservableList that was removed/replaced is disposed. Once this is done we can move on to adding the MultiList(IObservableList<IObservableList>) constructor
Ran out of time for 3.5
(In reply to comment #0) > It might be useful to add a method IListProperty.lists(IListProperty) to string > together a list of lists into one giant list. > > e.g. > > IListProperty children = BeanProperties.list("children"); > IObservableList grandChildren = children.lists(children).observe(person); Would one be able to observe deeper levels of ancestors? like: IObservableList greatGrandChildren = children.lists(children).lists(children).observe(person);
Yes, that's the general idea.
Removing obsolete target milestone.
This is something I have been wanting to do every now and then. I have not found a way to do it with the current databinding component. I will provide an implementation of this relatively shortly, using Matthews code as a starting point.
New Gerrit change created: https://git.eclipse.org/r/143157
New Gerrit change created: https://git.eclipse.org/r/143156
New Gerrit change created: https://git.eclipse.org/r/143155
The following Gerrit change contains an almost finished implementation of this feature (together with some tests): https://git.eclipse.org/r/#/c/143157/ Remaining work: * Think about is there is a better way to dispose nested lists. See: https://git.eclipse.org/r/#/c/143157/1/bundles/org.eclipse.core.databinding.property/src/org/eclipse/core/databinding/property/list/ListProperty.java@184 * Update staleness tracking. * Write a few more tests. * Finish documentation.
Gerrit change https://git.eclipse.org/r/143156 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac2f11f0e50fcba8ead9fd4c0cbf4ff3a77e89e8
(In reply to Eclipse Genie from comment #12) > Gerrit change https://git.eclipse.org/r/143156 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac2f11f0e50fcba8ead9fd4c0cbf4ff3a77e89e8 > -1 1. Start new workspace 2. Set 4.12 RC2 as API Baseline 3. Import the org.eclipse.core.databinding.observable ==> API Tools error Please fix, thanks.
(In reply to Dani Megert from comment #13) > (In reply to Eclipse Genie from comment #12) > > Gerrit change https://git.eclipse.org/r/143156 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ac2f11f0e50fcba8ead9fd4c0cbf4ff3a77e89e8 > > > -1 > > 1. Start new workspace > 2. Set 4.12 RC2 as API Baseline > 3. Import the org.eclipse.core.databinding.observable > ==> API Tools error > > Please fix, thanks. Also reported by the official build: https://download.eclipse.org/eclipse/downloads/drops4/I20190613-0210/apitools/analysis/html/org.eclipse.core.databinding.observable/report.html
New Gerrit change created: https://git.eclipse.org/r/143973
Reported the potential API tooling issue via https://bugs.eclipse.org/bugs/show_bug.cgi?id=548249
(In reply to Dani Megert from comment #14) > > Please fix, thanks. Workaround currently blocked by Danis -1 See https://git.eclipse.org/r/#/c/143973/
(In reply to Lars Vogel from comment #17) > (In reply to Dani Megert from comment #14) > > > Please fix, thanks. > > Workaround currently blocked by Danis -1 See > https://git.eclipse.org/r/#/c/143973/ Please see my comment in the Gerrit and bug 548249 comment 7.
Gerrit change https://git.eclipse.org/r/143973 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b33e413ebe4e2ce316dbe5a53a01f5a7874e2237
New Gerrit change created: https://git.eclipse.org/r/146797
New Gerrit change created: https://git.eclipse.org/r/146828
New Gerrit change created: https://git.eclipse.org/r/146859
This change is basically finished. I think this will be a useful addition to the databinding framework. It makes a pretty common task much simpler, prettier and more efficient. I have not removed the WIP flag yet, because I want to think through the solution for a while, to hopefully catch mistakes or misunderstandings if there are any. This change is divided into a number of sub-gerrits, where 4. contains the main implementation: 1. Cleanup MultiList (merged): https://git.eclipse.org/r/#/c/143156/ 2. Cleanup tests: https://git.eclipse.org/r/#/c/143155/ 3. Rename fields in MultiList: https://git.eclipse.org/r/#/c/146859/ 4. Add ListProperty#list: https://git.eclipse.org/r/#/c/143157/ 5. Add ListProperty#list overloads to Beans databinding: https://git.eclipse.org/r/#/c/146797/ Optional work that remains to do: * Create a databinding snipped which demonstrates this feature. * Update EMF databinding with specialised overloads for ListProperty#list (in the same way as for Beans databinding).
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
This feature would still be useful, I some day I hope to finish the implementation. I'm reopening.
