Bug 263440 - [Patch][Doc] No F1 help for GenerateDiffFileWizard
Summary: [Patch][Doc] No F1 help for GenerateDiffFileWizard
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard: hasPatch
Keywords: Documentation
Depends on:
Blocks: 71374
  Show dependency tree
 
Reported: 2009-02-03 05:47 EST by Kacper Zdanowicz CLA
Modified: 2019-09-06 15:37 EDT (History)
4 users (show)

See Also:


Attachments
Patch_v1 (3.56 KB, patch)
2009-03-29 11:53 EDT, mariusz.tanski CLA
no flags Details | Diff
Patch_v2 (3.16 KB, patch)
2009-04-01 06:50 EDT, Kacper Zdanowicz CLA
no flags Details | Diff
Patch_doc_user_v1 (1.82 KB, patch)
2009-04-01 06:53 EDT, Kacper Zdanowicz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kacper Zdanowicz CLA 2009-02-03 05:47:40 EST
Build ID: I20090114-1322

Steps To Reproduce:
1.Open any comparison of two files.
2.Right click on compare editor.
3.Choose 'Create Patch' to run wizard.
4.Press F1 to check, that help doesn't work.


More information:
This bug is associated with bug 71374 (Generate diff from "Compare With" ).
Generating a patch from any comaprison using wizard is a new feature, so it would be great to have an assistance available (F1 help).
Comment 1 Tomasz Zarna CLA 2009-02-03 05:59:41 EST
It's not I20090114-1322, the code is still not in HEAD. Comment 0 refers to the code from "branch_20090126_LocalDiff" branch.
Comment 2 mariusz.tanski CLA 2009-03-29 11:53:42 EDT
Created attachment 130183 [details]
Patch_v1

Patch 'patch_diff_help.txt' set help page for 'Create patch' wizard.
Comment 3 mariusz.tanski CLA 2009-03-29 16:09:03 EDT
Comment on attachment 130183 [details]
Patch_v1

add help for 'Create Patch' wizard
Comment 4 Tomasz Zarna CLA 2009-03-31 04:47:05 EDT
Mariusz, is this a complete patch? Hitting F1 does open Help section but it doesn't bring any meaningful information. 

btw, I would set the F1 help in the same place it is done in the original GenerateDiffFileWizard from CVS.
Comment 5 Tomasz Zarna CLA 2009-03-31 05:16:49 EDT
Given the current state of things and the fact that bug 71374 adds new options, so some user assistance is required, I'm setting this bug as blocker to bug 71374.
Comment 6 Kacper Zdanowicz CLA 2009-04-01 06:50:42 EDT
Created attachment 130536 [details]
Patch_v2

F1 help moved to the same place it is done in the original
GenerateDiffFileWizard from CVS.

Help attached to specific pages, not whole wizard.
Comment 7 Kacper Zdanowicz CLA 2009-04-01 06:53:13 EDT
Created attachment 130537 [details]
Patch_doc_user_v1

This is patch for project org.eclipse.platform.doc.user, content of the help added to proper file. 

This patch have to be applied together with the patch for org.eclipse.compare, for help to work properly on local diff wizard.
Comment 8 Tomasz Zarna CLA 2009-04-02 04:40:48 EDT
Looks good now, thanks.
Comment 9 Tomasz Zarna CLA 2009-04-10 05:06:53 EDT
Both patches will be applied as soon as we decide to merge the "local diff" branch back to the main stream. There is no reason to branch the doc project and apply the second patch there.
Comment 10 Eclipse Webmaster CLA 2019-09-06 15:37:52 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.